From: Richard Russon <rich@flatcap.org>
Date: Fri, 24 May 2019 22:24:04 +0000 (+0100)
Subject: test: improve test_mutt_buffer_alloc()
X-Git-Tag: 2019-10-25~188^2~14
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eb9717bd4b02ba6122014e4546ab6c97db3452e5;p=neomutt

test: improve test_mutt_buffer_alloc()
---

diff --git a/mutt/buffer.c b/mutt/buffer.c
index 60166c3c1..4ecb1f510 100644
--- a/mutt/buffer.c
+++ b/mutt/buffer.c
@@ -298,13 +298,13 @@ bool mutt_buffer_is_empty(const struct Buffer *buf)
  */
 struct Buffer *mutt_buffer_alloc(size_t size)
 {
-  struct Buffer *b = mutt_mem_calloc(1, sizeof(struct Buffer));
+  struct Buffer *buf = mutt_mem_calloc(1, sizeof(struct Buffer));
 
-  b->data = mutt_mem_calloc(1, size);
-  b->dptr = b->data;
-  b->dsize = size;
+  buf->data = mutt_mem_calloc(1, size);
+  buf->dptr = buf->data;
+  buf->dsize = size;
 
-  return b;
+  return buf;
 }
 
 /**
diff --git a/test/buffer/mutt_buffer_alloc.c b/test/buffer/mutt_buffer_alloc.c
index 576a649b0..96c6fb9e0 100644
--- a/test/buffer/mutt_buffer_alloc.c
+++ b/test/buffer/mutt_buffer_alloc.c
@@ -23,9 +23,21 @@
 #define TEST_NO_MAIN
 #include "acutest.h"
 #include "config.h"
+#include <stdbool.h>
 #include "mutt/mutt.h"
 
 void test_mutt_buffer_alloc(void)
 {
   // struct Buffer *mutt_buffer_alloc(size_t size);
+
+  size_t alloc_tests[] = { 0, 42, 1048576 };
+
+  for (size_t i = 0; i < mutt_array_size(alloc_tests); i++)
+  {
+    struct Buffer *buf = NULL;
+    TEST_CASE_("%lu", alloc_tests[i]);
+    buf = mutt_buffer_alloc(alloc_tests[i]);
+    TEST_CHECK(buf != NULL);
+    mutt_buffer_free(&buf);
+  }
 }