From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Tue, 17 Dec 2013 23:08:18 +0000 (-0700)
Subject: No need to use __signed.
X-Git-Tag: SUDO_1_8_9^2~24
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eb44a5ba5c687ff673cc2882be227ee1764f2e64;p=sudo

No need to use __signed.
---

diff --git a/config.h.in b/config.h.in
index 87b2c6122..a1d7bdb33 100644
--- a/config.h.in
+++ b/config.h.in
@@ -1052,10 +1052,6 @@
    __func__ */
 #undef __func__
 
-/* Define to `signed' or nothing if compiler does not support a signed type
-   qualifier. */
-#undef __signed
-
 /* Define to empty if `const' does not conform to ANSI C. */
 #undef const
 
diff --git a/configure b/configure
index 92a80df4b..11183931d 100755
--- a/configure
+++ b/configure
@@ -16115,21 +16115,6 @@ $as_echo "#define gid_t int" >>confdefs.h
 
 fi
 
-ac_fn_c_check_type "$LINENO" "__signed char" "ac_cv_type___signed_char" "$ac_includes_default"
-if test "x$ac_cv_type___signed_char" = xyes; then :
-
-else
-  ac_fn_c_check_type "$LINENO" "signed char" "ac_cv_type_signed_char" "$ac_includes_default"
-if test "x$ac_cv_type_signed_char" = xyes; then :
-  $as_echo "#define __signed signed" >>confdefs.h
-
-else
-  $as_echo "#define __signed /**/" >>confdefs.h
-
-fi
-
-fi
-
 ac_fn_c_check_type "$LINENO" "sig_atomic_t" "ac_cv_type_sig_atomic_t" "#include <sys/types.h>
 #include <signal.h>
 "
@@ -24428,6 +24413,5 @@ fi
 
 
 
-
 
 
diff --git a/configure.ac b/configure.ac
index 086cb61a3..22d70a647 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2182,7 +2182,6 @@ dnl
 SUDO_APPEND_CPPFLAGS(-D__STDC_WANT_LIB_EXT1__=1)
 AC_TYPE_MODE_T
 AC_TYPE_UID_T
-AC_CHECK_TYPE([__signed char], [], [AC_CHECK_TYPE([signed char], [AC_DEFINE(__signed, signed)], [AC_DEFINE(__signed, [])])])
 AC_CHECK_TYPE([sig_atomic_t], [], [AC_DEFINE(sig_atomic_t, int)], [#include <sys/types.h>
 #include <signal.h>])
 AC_CHECK_TYPES([sigaction_t], [], [], [#include <sys/types.h>
@@ -3842,7 +3841,6 @@ AH_TEMPLATE(USE_INSULTS, [Define to 1 if you want to insult the user for enterin
 AH_TEMPLATE(USE_STOW, [Define to 1 if you use GNU stow packaging.])
 AH_TEMPLATE(WITHOUT_PASSWD, [Define to avoid using the passwd/shadow file for authentication.])
 AH_TEMPLATE(sig_atomic_t, [Define to `int' if <signal.h> does not define.])
-AH_TEMPLATE(__signed, [Define to `signed' or nothing if compiler does not support a signed type qualifier.])
 AH_TEMPLATE(socklen_t, [Define to `unsigned int' if <sys/socket.h> doesn't define.])
 AH_TEMPLATE(HAVE_STRUCT_UTMP_UT_EXIT, [Define to 1 if `ut_exit' is a member of `struct utmp'.])
 AH_TEMPLATE(HAVE_STRUCT_UTMPX_UT_EXIT, [Define to 1 if `ut_exit' is a member of `struct utmpx'.])
diff --git a/plugins/sudoers/parse.h b/plugins/sudoers/parse.h
index bcdc9503b..9af302b00 100644
--- a/plugins/sudoers/parse.h
+++ b/plugins/sudoers/parse.h
@@ -53,11 +53,11 @@ struct sudo_command {
  * Possible values: true, false, IMPLIED, UNSPEC.
  */
 struct cmndtag {
-    __signed int nopasswd: 3;
-    __signed int noexec: 3;
-    __signed int setenv: 3;
-    __signed int log_input: 3;
-    __signed int log_output: 3;
+    int nopasswd: 3;
+    int noexec: 3;
+    int setenv: 3;
+    int log_input: 3;
+    int log_output: 3;
 };
 
 /*