From: Evgeniy Stepanov <eugeni.stepanov@gmail.com>
Date: Mon, 4 Dec 2017 22:50:39 +0000 (+0000)
Subject: [msan] Add a fixme note for a minor deficiency.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eb42c992dfcd4c048d8e0dd73fcc6f4850446e74;p=llvm

[msan] Add a fixme note for a minor deficiency.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@319708 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Instrumentation/MemorySanitizer.cpp b/lib/Transforms/Instrumentation/MemorySanitizer.cpp
index 44190a2c312..c034a833bed 100644
--- a/lib/Transforms/Instrumentation/MemorySanitizer.cpp
+++ b/lib/Transforms/Instrumentation/MemorySanitizer.cpp
@@ -2772,6 +2772,8 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
         setOrigin(&I, getCleanOrigin());
         return;
       }
+      // FIXME: NextInsn is likely in a basic block that has not been visited yet.
+      // Anything inserted there will be instrumented by MSan later!
       NextInsn = NormalDest->getFirstInsertionPt();
       assert(NextInsn != NormalDest->end() &&
              "Could not find insertion point for retval shadow load");