From: Emily Morehouse <emily@cuttlesoft.com>
Date: Tue, 27 Jun 2017 16:08:47 +0000 (-0600)
Subject: [3.5] bpo-30769: Fix reference leak introduced in 7770394 (GH-2416) (#2447)
X-Git-Tag: v3.5.4rc1~40
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eb3c52a0d273491e745e0cbff2b73900bb96aa45;p=python

[3.5] bpo-30769: Fix reference leak introduced in 7770394 (GH-2416) (#2447)
---

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 042deaca6f..8d32ddf131 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -4969,6 +4969,8 @@ parse_envlist(PyObject* env, Py_ssize_t *envc_ptr)
         /* Search from index 1 because on Windows starting '=' is allowed for
            defining hidden environment variables. */
         if (*k == '\0' || strchr(k + 1, '=') != NULL) {
+            Py_DECREF(key2);
+            Py_DECREF(val2);
             PyErr_SetString(PyExc_ValueError, "illegal environment variable name");
             goto error;
         }