From: Johannes Schlüter <johannes@php.net>
Date: Thu, 11 Feb 2010 21:42:48 +0000 (+0000)
Subject: revert 293939 Fixed bug #50636 (MySQLi_Result sets values before calling
X-Git-Tag: php-5.4.0alpha1~305
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eb0de2af90bf4b2f07b56d48355e02b73e4c7ee4;p=php

revert 293939 Fixed bug #50636 (MySQLi_Result sets values before calling
constructor)
---

diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c
index 266329e32d..0f5bc71c63 100644
--- a/ext/mysqli/mysqli.c
+++ b/ext/mysqli/mysqli.c
@@ -1204,6 +1204,7 @@ void php_mysqli_fetch_into_hash(INTERNAL_FUNCTION_PARAMETERS, int override_flags
 		zval *retval_ptr; 
 
 		object_and_properties_init(return_value, ce, NULL);
+		zend_merge_properties(return_value, Z_ARRVAL(dataset), 1 TSRMLS_CC);
 
 		if (ce->constructor) {
 			fci.size = sizeof(fci);
@@ -1259,8 +1260,6 @@ void php_mysqli_fetch_into_hash(INTERNAL_FUNCTION_PARAMETERS, int override_flags
 		} else if (ctor_params) {
 			zend_throw_exception_ex(zend_exception_get_default(TSRMLS_C), 0 TSRMLS_CC, "Class %s does not have a constructor hence you cannot use ctor_params", ce->name);
 		}
-
-		zend_merge_properties(return_value, Z_ARRVAL(dataset), 1 TSRMLS_CC);
 	}
 }
 /* }}} */
diff --git a/ext/mysqli/tests/bug50636.phpt b/ext/mysqli/tests/bug50636.phpt
deleted file mode 100644
index 47f27721e4..0000000000
--- a/ext/mysqli/tests/bug50636.phpt
+++ /dev/null
@@ -1,35 +0,0 @@
---TEST--
-Bug #50636 (MySQLi_Result sets values before calling constructor)
---SKIPIF--
-<?php
-require_once('skipif.inc');
-require_once('skipifconnectfailure.inc');
-?>
---FILE--
-<?php
-	include ("connect.inc");
-
-    class Book {
-        private $title = 0;
-
-        function __construct() {
-            $this->title = 'foobar';
-        }
-
-        function __set($name, $value) {
-            $this->{$name}   = $value;
-        }
-    }
-
-    $link = new mysqli($host, $user, $passwd);
-    var_dump($link->query('SELECT "PHP" AS title, "Rasmus" AS author')->fetch_object('Book'));
-    echo "done!";
-?>
---EXPECTF--
-object(Book)#%d (2) {
-  ["title":"Book":private]=>
-  string(3) "PHP"
-  ["author"]=>
-  string(6) "Rasmus"
-}
-done!