From: Nico Weber <nicolasweber@gmx.de>
Date: Sun, 14 Apr 2019 23:08:12 +0000 (+0000)
Subject: llvm-undname: Fix another crash-on-invalid found by oss-fuzz
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eaedc0223b81be365f4d2ee28b438765665fbdda;p=llvm

llvm-undname: Fix another crash-on-invalid found by oss-fuzz

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358363 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Demangle/MicrosoftDemangle.cpp b/lib/Demangle/MicrosoftDemangle.cpp
index 719e716a886..882913a9863 100644
--- a/lib/Demangle/MicrosoftDemangle.cpp
+++ b/lib/Demangle/MicrosoftDemangle.cpp
@@ -654,7 +654,10 @@ Demangler::translateIntrinsicFunctionCode(char CH,
 IdentifierNode *
 Demangler::demangleFunctionIdentifierCode(StringView &MangledName,
                                           FunctionIdentifierCodeGroup Group) {
-  assert(!MangledName.empty());
+  if (MangledName.empty()) {
+    Error = true;
+    return nullptr;
+  }
   switch (Group) {
   case FunctionIdentifierCodeGroup::Basic:
     switch (char CH = MangledName.popFront()) {
diff --git a/test/Demangle/invalid-manglings.test b/test/Demangle/invalid-manglings.test
index 473b3e4bbe1..eb22d1e0a4c 100644
--- a/test/Demangle/invalid-manglings.test
+++ b/test/Demangle/invalid-manglings.test
@@ -114,3 +114,8 @@
 ; CHECK-EMPTY:
 ; CHECK-NEXT: ??}
 ; CHECK-NEXT: error: Invalid mangled name
+
+?foo@?$?_
+; CHECK-EMPTY:
+; CHECK-NEXT: ?foo@?$?_
+; CHECK-NEXT: error: Invalid mangled name