From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Fri, 6 Sep 2019 07:31:16 +0000 (+0200)
Subject: Always reset Boost beast buffer in HttpServerConnection#ProcessMessages
X-Git-Tag: v2.11.0~1^2~16^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eabba2de423539acd118e83b28a19544ae1a101d;p=icinga2

Always reset Boost beast buffer in HttpServerConnection#ProcessMessages

refs #7431
---

diff --git a/lib/remote/httpserverconnection.cpp b/lib/remote/httpserverconnection.cpp
index e2db0641e..88a0af5fb 100644
--- a/lib/remote/httpserverconnection.cpp
+++ b/lib/remote/httpserverconnection.cpp
@@ -475,6 +475,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc)
 
 			response.set(http::field::server, l_ServerHeader);
 
+			// Best practice is to always reset the buffer.
+			buf = {};
 			if (!EnsureValidHeaders(*m_Stream, buf, parser, response, yc)) {
 				break;
 			}
@@ -520,6 +522,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc)
 				break;
 			}
 
+			// Best practice is to always reset the buffer.
+			buf = {};
 			if (!EnsureValidBody(*m_Stream, buf, parser, authenticatedUser, response, yc)) {
 				break;
 			}