From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Thu, 8 Oct 2009 04:46:21 +0000 (+0000)
Subject: Fix off-by-one bug in bitncmp(): When comparing a number of bits divisible by
X-Git-Tag: REL8_5_ALPHA2~31
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eab94d8182691aa64126736c546d7c5215187d79;p=postgresql

Fix off-by-one bug in bitncmp(): When comparing a number of bits divisible by
8, bitncmp() may dereference a pointer one byte out of bounds.

Chris Mikkelson (bug #5101)
---

diff --git a/src/backend/utils/adt/network.c b/src/backend/utils/adt/network.c
index f4fc67a843..0ea13fc47b 100644
--- a/src/backend/utils/adt/network.c
+++ b/src/backend/utils/adt/network.c
@@ -1,7 +1,7 @@
 /*
  *	PostgreSQL type definitions for the INET and CIDR types.
  *
- *	$PostgreSQL: pgsql/src/backend/utils/adt/network.c,v 1.74 2009/06/11 14:49:03 momjian Exp $
+ *	$PostgreSQL: pgsql/src/backend/utils/adt/network.c,v 1.75 2009/10/08 04:46:21 heikki Exp $
  *
  *	Jon Postel RIP 16 Oct 1998
  */
@@ -972,7 +972,7 @@ bitncmp(void *l, void *r, int n)
 
 	b = n / 8;
 	x = memcmp(l, r, b);
-	if (x)
+	if (x || (n % 8) == 0)
 		return x;
 
 	lb = ((const u_char *) l)[b];