From: Stefan Fritsch <sf@apache.org>
Date: Thu, 10 Jun 2010 21:10:27 +0000 (+0000)
Subject: Prevent segfault if URI is missing a scheme
X-Git-Tag: 2.3.6~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ea8e8784462d3dc9f8c9adbede9612a330528518;p=apache

Prevent segfault if URI is missing a scheme


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@953459 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/mod_serf.c b/modules/proxy/mod_serf.c
index 3a8696b250..929ba35b44 100644
--- a/modules/proxy/mod_serf.c
+++ b/modules/proxy/mod_serf.c
@@ -665,6 +665,10 @@ static const char *add_pass(cmd_parms *cmd, void *vconf,
         return "mod_serf: Unable to parse SerfPass url.";
     }
 
+    if (!conf->url.scheme) {
+        return "mod_serf: Need scheme part in url.";
+    }
+
     /* XXXX: These are bugs in apr_uri_parse. Fixme. */
     if (!conf->url.port) {
         conf->url.port = apr_uri_port_of_scheme(conf->url.scheme);