From: R David Murray <rdmurray@bitdance.com>
Date: Tue, 17 Dec 2013 17:09:46 +0000 (-0500)
Subject: 20004: Note that the setter in csv.DictReader is broken.
X-Git-Tag: v2.7.8~189
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ea76e87cc26727d6ec8a139b3c9411154212e2ea;p=python

20004: Note that the setter in csv.DictReader is broken.

This is a comment in the code because only someone reading the code would try
setting fieldnames to None in the first place...
---

diff --git a/Lib/csv.py b/Lib/csv.py
index fc080cce1b..c155ada794 100644
--- a/Lib/csv.py
+++ b/Lib/csv.py
@@ -93,6 +93,10 @@ class DictReader:
         self.line_num = self.reader.line_num
         return self._fieldnames
 
+    # Issue 20004: Because DictReader is a classic class, this setter is
+    # ignored.  At this point in 2.7's lifecycle, it is too late to change the
+    # base class for fear of breaking working code.  If you want to change
+    # fieldnames without overwriting the getter, set _fieldnames directly.
     @fieldnames.setter
     def fieldnames(self, value):
         self._fieldnames = value