From: Martin v. Löwis <martin@v.loewis.de>
Date: Tue, 12 Feb 2008 18:48:23 +0000 (+0000)
Subject: Patch #1966: Break infinite loop in httplib when the servers
X-Git-Tag: v2.5.2c1~14
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e9c996c14db994fb0afe806a0eee16a97b587fc1;p=python

Patch #1966: Break infinite loop in httplib when the servers
implements the chunked encoding incorrectly.
---

diff --git a/Lib/httplib.py b/Lib/httplib.py
index 403e4eed00..137a9eaa8a 100644
--- a/Lib/httplib.py
+++ b/Lib/httplib.py
@@ -571,6 +571,10 @@ class HTTPResponse:
         ### note: we shouldn't have any trailers!
         while True:
             line = self.fp.readline()
+            if not line:
+                # a vanishingly small number of sites EOF without
+                # sending the trailer
+                break
             if line == '\r\n':
                 break
 
diff --git a/Misc/NEWS b/Misc/NEWS
index ffb1771ff5..6ea4eeaec3 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -83,6 +83,9 @@ Core and builtins
 Library
 -------
 
+- Patch #1966: Break infinite loop in httplib when the servers
+  implements the chunked encoding incorrectly.
+
 - tarfile.py: Fix reading of xstar archives.
 
 - #2021: Allow tempfile.NamedTemporaryFile to be used in with statements