From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 22 Feb 2010 15:26:14 +0000 (+0000)
Subject: Adjust pg_fsync_writethrough so that it will set errno when failing
X-Git-Tag: REL9_0_ALPHA5~232
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e9a383303ce2f47a2733419e8d23e9e5a20b5ff2;p=postgresql

Adjust pg_fsync_writethrough so that it will set errno when failing
on a platform that doesn't support this operation.  The former coding
would allow an unrelated errno to be reported, which would be quite
misleading.  Not sure if this has anything to do with the current
buildfarm failures, but it's certainly bogus as-is.
---

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index adea849ab0..06edf062c1 100644
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.154 2010/02/15 00:50:57 stark Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.155 2010/02/22 15:26:14 tgl Exp $
  *
  * NOTES:
  *
@@ -292,6 +292,7 @@ pg_fsync_writethrough(int fd)
 #elif defined(F_FULLFSYNC)
 		return (fcntl(fd, F_FULLFSYNC, 0) == -1) ? -1 : 0;
 #else
+		errno = ENOSYS;
 		return -1;
 #endif
 	}