From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Sat, 7 May 2016 11:10:11 +0000 (-0600)
Subject: In sudo_edit_create_tfiles(), fix fd leak if sudo_edit_mktemp() fails.
X-Git-Tag: SUDO_1_8_17^2~82
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e99e3c26c855bd47d82a9b72f901e7d789453eeb;p=sudo

In sudo_edit_create_tfiles(), fix fd leak if sudo_edit_mktemp() fails.
Coverity CID 104114.
---

diff --git a/src/sudo_edit.c b/src/sudo_edit.c
index 8679f7e2e..1661899e4 100644
--- a/src/sudo_edit.c
+++ b/src/sudo_edit.c
@@ -558,6 +558,8 @@ sudo_edit_create_tfiles(struct command_details *command_details,
 	    sudo_fatal("seteuid(ROOT_UID)");
 	if (tfd == -1) {
 	    sudo_warn("mkstemps");
+	    if (ofd != -1)
+		close(ofd);
 	    debug_return_int(-1);
 	}
 	if (ofd != -1) {