From: Martin v. Löwis <martin@v.loewis.de>
Date: Thu, 30 Aug 2007 18:14:01 +0000 (+0000)
Subject: Fix popen usage.
X-Git-Tag: v2.6a1~1380
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e89cd17dfa0f6a58a01aecdd050d1d61f492c53d;p=python

Fix popen usage.
---

diff --git a/Tools/msi/msilib.py b/Tools/msi/msilib.py
index 548b640bc3..ca7e311e25 100644
--- a/Tools/msi/msilib.py
+++ b/Tools/msi/msilib.py
@@ -390,8 +390,8 @@ class CAB:
             cabarc = "cabarc.exe"
         cmd = r'"%s" -m lzx:21 n %s.cab @%s.txt' % (cabarc, self.name, self.name)
         p = subprocess.Popen(cmd, shell=True, stdin=subprocess.PIPE,
-                             stdout=subprocess.PIPE, stderr=subprocess.STDOUT)[0]
-        for line in (p.stdout, p.stdin):
+                             stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+        for line in p.stdout:
             if line.startswith("  -- adding "):
                 sys.stdout.write(".")
             else: