From: foobar Date: Wed, 8 Oct 2003 10:22:51 +0000 (+0000) Subject: - Fixed bug #25780 (ext/session: invalid session.cookie_lifetime causes crash in... X-Git-Tag: RELEASE_1_3b3~90 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e85a4cdbd20384d707c4e2afdfe48f1ca0896b59;p=php - Fixed bug #25780 (ext/session: invalid session.cookie_lifetime causes crash in win32). --- diff --git a/ext/session/session.c b/ext/session/session.c index 22521626b8..0eac74f327 100644 --- a/ext/session/session.c +++ b/ext/session/session.c @@ -957,13 +957,17 @@ static void php_session_send_cookie(TSRMLS_D) if (PS(cookie_lifetime) > 0) { struct timeval tv; + time_t t; gettimeofday(&tv, NULL); - date_fmt = php_std_date(tv.tv_sec + PS(cookie_lifetime) TSRMLS_CC); + t = tv.tv_sec + PS(cookie_lifetime); - smart_str_appends(&ncookie, COOKIE_EXPIRES); - smart_str_appends(&ncookie, date_fmt); - efree(date_fmt); + if (t > 0) { + date_fmt = php_std_date(t TSRMLS_CC); + smart_str_appends(&ncookie, COOKIE_EXPIRES); + smart_str_appends(&ncookie, date_fmt); + efree(date_fmt); + } } if (PS(cookie_path)[0]) {