From: Fariborz Jahanian <fjahanian@apple.com>
Date: Thu, 13 Aug 2009 00:53:36 +0000 (+0000)
Subject: Minor refactoring of copy assign operator ir-gen. SWIP.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e82c3e269f0edd6d531b93114e97573792e808e0;p=clang

Minor refactoring of copy assign operator ir-gen. SWIP.



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@78875 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CGCXX.cpp b/lib/CodeGen/CGCXX.cpp
index b378bf83e6..4148d7b717 100644
--- a/lib/CodeGen/CGCXX.cpp
+++ b/lib/CodeGen/CGCXX.cpp
@@ -840,26 +840,29 @@ void CodeGenFunction::EmitClassCopyAssignment(
   }
   
   const CXXMethodDecl *MD = 0;
-  if (BaseClassDecl->hasConstCopyAssignment(getContext(), MD)) {
-    const FunctionProtoType *FPT = MD->getType()->getAsFunctionProtoType();
-    const llvm::Type *Ty = 
-      CGM.getTypes().GetFunctionType(CGM.getTypes().getFunctionInfo(MD), 
-                                     FPT->isVariadic());
-    llvm::Constant *Callee = CGM.GetAddrOfFunction(GlobalDecl(MD), Ty);
+  bool ConstCopyAssignOp = BaseClassDecl->hasConstCopyAssignment(getContext(), 
+                                                                 MD);
+  assert(ConstCopyAssignOp && "EmitClassCopyAssignment - missing copy assign");
+  (void)ConstCopyAssignOp;
+
+  const FunctionProtoType *FPT = MD->getType()->getAsFunctionProtoType();
+  const llvm::Type *LTy = 
+    CGM.getTypes().GetFunctionType(CGM.getTypes().getFunctionInfo(MD), 
+                                   FPT->isVariadic());
+  llvm::Constant *Callee = CGM.GetAddrOfFunction(GlobalDecl(MD), LTy);
     
-    CallArgList CallArgs;
-    // Push the this (Dest) ptr.
-    CallArgs.push_back(std::make_pair(RValue::get(Dest),
-                                      MD->getThisType(getContext())));
+  CallArgList CallArgs;
+  // Push the this (Dest) ptr.
+  CallArgs.push_back(std::make_pair(RValue::get(Dest),
+                                    MD->getThisType(getContext())));
     
-    // Push the Src ptr.
-    CallArgs.push_back(std::make_pair(RValue::get(Src),
-                                      MD->getParamDecl(0)->getType()));
-    QualType ResultType = 
-      MD->getType()->getAsFunctionType()->getResultType();
-    EmitCall(CGM.getTypes().getFunctionInfo(ResultType, CallArgs),
-             Callee, CallArgs, MD);
-  }
+  // Push the Src ptr.
+  CallArgs.push_back(std::make_pair(RValue::get(Src),
+                                    MD->getParamDecl(0)->getType()));
+  QualType ResultType = 
+    MD->getType()->getAsFunctionType()->getResultType();
+  EmitCall(CGM.getTypes().getFunctionInfo(ResultType, CallArgs),
+           Callee, CallArgs, MD);
 }
 
 /// SynthesizeDefaultConstructor - synthesize a default constructor