From: Michael Meskes <meskes@postgresql.org>
Date: Sun, 8 Sep 2013 10:59:43 +0000 (+0200)
Subject: Return error if allocation of new element was not possible.
X-Git-Tag: REL9_2_5~19
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e8193088f12ecc221692af3cf5f51c782e815f46;p=postgresql

Return error if allocation of new element was not possible.

Found by Coverity.
---

diff --git a/src/interfaces/ecpg/pgtypeslib/numeric.c b/src/interfaces/ecpg/pgtypeslib/numeric.c
index 7257c81254..55c5b45616 100644
--- a/src/interfaces/ecpg/pgtypeslib/numeric.c
+++ b/src/interfaces/ecpg/pgtypeslib/numeric.c
@@ -430,14 +430,18 @@ PGTYPESnumeric_to_asc(numeric *num, int dscale)
 	numeric    *numcopy = PGTYPESnumeric_new();
 	char	   *s;
 
-	if (dscale < 0)
-		dscale = num->dscale;
+	if (numcopy == NULL)
+		return NULL;
 
 	if (PGTYPESnumeric_copy(num, numcopy) < 0)
 	{
 		PGTYPESnumeric_free(numcopy);
 		return NULL;
 	}
+
+	if (dscale < 0)
+		dscale = num->dscale;
+
 	/* get_str_from_var may change its argument */
 	s = get_str_from_var(numcopy, dscale);
 	PGTYPESnumeric_free(numcopy);
@@ -1520,6 +1524,9 @@ numericvar_to_double(numeric *var, double *dp)
 	char	   *endptr;
 	numeric    *varcopy = PGTYPESnumeric_new();
 
+	if (varcopy == NULL)
+		return -1;
+
 	if (PGTYPESnumeric_copy(var, varcopy) < 0)
 	{
 		PGTYPESnumeric_free(varcopy);