From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 28 May 2002 22:15:42 +0000 (+0000)
Subject: In default nextval('foo') expression for a SERIAL column, use double
X-Git-Tag: REL7_3~1481
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e80d6a1bac8dcafe81679797f661e75201355f2b;p=postgresql

In default nextval('foo') expression for a SERIAL column, use double
quotes only when necessary.
---

diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c
index 72a0c8be51..916067a1d0 100644
--- a/src/backend/parser/analyze.c
+++ b/src/backend/parser/analyze.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.234 2002/05/12 20:10:03 tgl Exp $
+ *	$Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.235 2002/05/28 22:15:42 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -856,8 +856,7 @@ transformColumnDefinition(ParseState *pstate, CreateStmtContext *cxt,
 		 * Create an expression tree representing the function call
 		 * nextval('"sequencename"')
 		 */
-		qstring = palloc(strlen(snamespace) + strlen(sname) + 5 + 1);
-		sprintf(qstring, "\"%s\".\"%s\"", snamespace, sname);
+		qstring = quote_qualified_identifier(snamespace, sname);
 		snamenode = makeNode(A_Const);
 		snamenode->val.type = T_String;
 		snamenode->val.val.str = qstring;