From: Victor Stinner <victor.stinner@gmail.com>
Date: Wed, 2 Sep 2015 13:46:00 +0000 (+0200)
Subject: test_gdb: fix ResourceWarning if the test is interrupted
X-Git-Tag: v3.6.0a1~1703
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e801c36037bf3875de0ecbb79c9f9ba8938027da;p=python

test_gdb: fix ResourceWarning if the test is interrupted
---

diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
index 193c97afa3..a51b552503 100644
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -63,9 +63,11 @@ def run_gdb(*args, **env_vars):
     base_cmd = ('gdb', '--batch', '-nx')
     if (gdb_major_version, gdb_minor_version) >= (7, 4):
         base_cmd += ('-iex', 'add-auto-load-safe-path ' + checkout_hook_path)
-    out, err = subprocess.Popen(base_cmd + args,
-        stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env,
-        ).communicate()
+    proc = subprocess.Popen(base_cmd + args,
+                            stdout=subprocess.PIPE,
+                            stderr=subprocess.PIPE, env=env)
+    with proc:
+        out, err = proc.communicate()
     return out.decode('utf-8', 'replace'), err.decode('utf-8', 'replace')
 
 # Verify that "gdb" was built with the embedded python support enabled: