From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Mon, 10 Oct 2022 15:03:46 +0000 (-0700)
Subject: smyrna savefiledlg: remove filter parameters
X-Git-Tag: 7.0.0~8^2~5
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e7fb9a1b807a14d39a777fe137eb09adf2bd0329;p=graphviz

smyrna savefiledlg: remove filter parameters

This function is only ever called without any filters.
---

diff --git a/cmd/smyrna/gui/gui.c b/cmd/smyrna/gui/gui.c
index 860bd4cfa..4c148f298 100644
--- a/cmd/smyrna/gui/gui.c
+++ b/cmd/smyrna/gui/gui.c
@@ -145,17 +145,9 @@ int openfiledlg(char **filename) {
     return rv;
 }
 
-int savefiledlg(int filtercnt, char **filters, agxbuf * xbuf)
-{
+int savefiledlg(agxbuf *xbuf) {
     GtkWidget *dialog;
-    GtkFileFilter *filter;
-    int id, rv;
-    filter = gtk_file_filter_new();
-    if (filtercnt >= 1) {
-	for (id = 0; id < filtercnt; id++) {
-	    gtk_file_filter_add_pattern(filter, filters[id]);
-	}
-    }
+    int rv;
 
     dialog = gtk_file_chooser_dialog_new("Save File",
 					 NULL,
@@ -165,8 +157,6 @@ int savefiledlg(int filtercnt, char **filters, agxbuf * xbuf)
 					 GTK_STOCK_OPEN,
 					 GTK_RESPONSE_ACCEPT, NULL);
 
-    if (filtercnt >= 1)
-	gtk_file_chooser_set_filter((GtkFileChooser *) dialog, filter);
     if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) {
 	agxbput(xbuf,
 		gtk_file_chooser_get_filename(GTK_FILE_CHOOSER(dialog)));
diff --git a/cmd/smyrna/gui/gui.h b/cmd/smyrna/gui/gui.h
index fff7e412f..f903caad4 100644
--- a/cmd/smyrna/gui/gui.h
+++ b/cmd/smyrna/gui/gui.h
@@ -43,5 +43,5 @@
  */
     int openfiledlg(char **filename);
 /*generic save file dialog*/
-    int savefiledlg(int filtercnt, char **filters, agxbuf * xbuf);
+    int savefiledlg(agxbuf * xbuf);
     void append_textview(GtkTextView * textv, const char *s, size_t bytes);
diff --git a/cmd/smyrna/gui/menucallbacks.c b/cmd/smyrna/gui/menucallbacks.c
index bf8a3eb68..a9542c02f 100644
--- a/cmd/smyrna/gui/menucallbacks.c
+++ b/cmd/smyrna/gui/menucallbacks.c
@@ -403,7 +403,7 @@ void on_gvprbuttonsave_clicked(GtkWidget * widget, gpointer user_data)
     GtkTextIter endit;
 
     /*file name should be returned in xbuf */
-    if (savefiledlg(0, NULL, &xbuf)) {
+    if (savefiledlg(&xbuf)) {
 	output_file = fopen(agxbuse(&xbuf), "w");
 	if (output_file) {
 	    gtkbuf =