From: Dmitry V. Levin <ldv@altlinux.org>
Date: Thu, 5 Jan 2017 18:20:57 +0000 (+0000)
Subject: tests: skip readahead.test on MIPS n64 when built with glibc < 2.25
X-Git-Tag: v4.16~90
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e752ef61c3fa2d204e0fe2a0781fe8931c81eff9;p=strace

tests: skip readahead.test on MIPS n64 when built with glibc < 2.25

Due to a bug in glibc readahead syscall wrapper on MIPS n64,
this wrapper cannot be used in readahead.test.

* tests/readahead.c [HAVE_READAHEAD && LINUX_MIPSN64 && glibc < 2.25]:
Undefine HAVE_READAHEAD.

Reported-by: James Cowgill <james410@cowgill.org.uk>
---

diff --git a/tests/readahead.c b/tests/readahead.c
index 2b28dda1..c11b577d 100644
--- a/tests/readahead.c
+++ b/tests/readahead.c
@@ -29,15 +29,24 @@
 #include <asm/unistd.h>
 
 #ifdef HAVE_READAHEAD
+/* Check for glibc readahead argument passing bugs. */
 # ifdef __GLIBC__
 /*
- * Check for glibc readahead off64_t argument passing bug,
+ * glibc < 2.8 had an incorrect order of higher and lower parts of offset,
  * see https://sourceware.org/bugzilla/show_bug.cgi?id=5208
  */
 #  if !(defined __GLIBC_MINOR__ && \
         (__GLIBC__ << 16) + __GLIBC_MINOR__ >= (2 << 16) + 8)
 #   undef HAVE_READAHEAD
-#  endif
+#  endif /* glibc < 2.8 */
+/*
+ * glibc < 2.25 had an incorrect implementation on mips n64,
+ * see https://sourceware.org/bugzilla/show_bug.cgi?id=21026
+ */
+#  if defined LINUX_MIPSN64 && !(defined __GLIBC_MINOR__ && \
+        (__GLIBC__ << 16) + __GLIBC_MINOR__ >= (2 << 16) + 25)
+#   undef HAVE_READAHEAD
+#  endif /* LINUX_MIPSN64 && glibc < 2.25 */
 # endif /* __GLIBC__ */
 #endif /* HAVE_READAHEAD */