From: Bruce Momjian <bruce@momjian.us>
Date: Thu, 20 Mar 2003 04:49:18 +0000 (+0000)
Subject: > Mph.  It fails for me too when I use --enable-integer-datetimes.  Looks
X-Git-Tag: REL7_4_BETA1~901
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e733510d5d67a0b4fb1a9228df598034e487f194;p=postgresql

> Mph.  It fails for me too when I use --enable-integer-datetimes.  Looks
> like that patch still needs some work...

Yeah.  I'm really, really, *really* sorry for submitting it in the state
it was in.  I shouldn't have done that just before moving to another
country.  I found the problem last night, but couldn't get to a Net
connection until now.

The problem is in src/bin/psql/common.c, around line 250-335 somewhere
depending on the version.  The 2nd and 3rd clauses of the "while" loop
condition:

        (rstatus == PGRES_COPY_IN) &&
        (rstatus == PGRES_COPY_OUT))

should of course be:

        (rstatus != PGRES_COPY_IN) &&
        (rstatus != PGRES_COPY_OUT))

Jeroen T. Vermeulen
---

diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c
index 5d7180f993..e5a2c0bc8a 100644
--- a/src/bin/psql/common.c
+++ b/src/bin/psql/common.c
@@ -3,7 +3,7 @@
  *
  * Copyright 2000 by PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.57 2003/03/18 22:15:44 petere Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.58 2003/03/20 04:49:18 momjian Exp $
  */
 #include "postgres_fe.h"
 #include "common.h"
@@ -252,8 +252,8 @@ PSQLexec(const char *query, bool ignore_command_ok)
 			}
 			PQclear(res);
 			res = newres;
-			if (rstatus == PGRES_COPY_IN ||
-				rstatus == PGRES_COPY_OUT)
+			if (rstatus != PGRES_COPY_IN &&
+				rstatus != PGRES_COPY_OUT)
 				break;
 		}
 	}