From: Ted Kremenek <kremenek@apple.com>
Date: Thu, 28 Jan 2010 23:56:52 +0000 (+0000)
Subject: Fix off-by-one error in ParseFormatSpecifier() when reporting the location of a null... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e729acbba75903f42e79e72e46cdebe3f4c35521;p=clang

Fix off-by-one error in ParseFormatSpecifier() when reporting the location of a null character.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@94762 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/PrintfFormatString.cpp b/lib/Analysis/PrintfFormatString.cpp
index 544956ac41..986411fc7d 100644
--- a/lib/Analysis/PrintfFormatString.cpp
+++ b/lib/Analysis/PrintfFormatString.cpp
@@ -89,16 +89,15 @@ static FormatSpecifierResult ParseFormatSpecifier(FormatStringHandler &H,
   UpdateOnReturn <const char*> UpdateBeg(Beg, I);
 
   // Look for a '%' character that indicates the start of a format specifier.
-  while (I != E) {
+  for ( ; I != E ; ++I) {
     char c = *I;
-    ++I;    
     if (c == '\0') {
       // Detect spurious null characters, which are likely errors.
       H.HandleNullChar(I);
       return true;
     }
     if (c == '%') {
-      Start = I;  // Record the start of the format specifier.
+      Start = I++;  // Record the start of the format specifier.
       break;
     }
   }