From: Thies C. Arntzen <thies@php.net>
Date: Sat, 13 Apr 2002 12:14:02 +0000 (+0000)
Subject: MFH: Mixing OCIPlogon and OCINLogon no longer leak Oracle-Sessions. (thies)
X-Git-Tag: php-4.2.0RC4~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e70afa0c54cdfb039b29eb8a5dc72b75514dd654;p=php

MFH: Mixing OCIPlogon and OCINLogon no longer leak Oracle-Sessions. (thies)
to RM: this is a real fix that _should_ be in 4.2!
---

diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index 988b4bc5d5..c0eedc8393 100644
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -2578,7 +2578,13 @@ static void oci_do_connect(INTERNAL_FUNCTION_PARAMETERS,int persistent,int exclu
 		goto CLEANUP;
 	}
 
-	persistent = server->persistent; /* if our server-context is not persistent we can't */
+	if (exclusive) {
+		/* exlusive session can never be persistent!*/
+		persistent = 0;
+	} else {
+		/* if our server-context is not persistent we can't */
+		persistent = server->persistent; 
+	}
 
 	session = _oci_open_session(server,username,password,persistent,exclusive);