From: Guido van Rossum <guido@python.org>
Date: Wed, 7 Nov 2007 01:19:49 +0000 (+0000)
Subject: Backport r58892.
X-Git-Tag: v2.5.2c1~141
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e6a6f39cc7eacb80e7f30e345063b933ce2f59de;p=python

Backport r58892.
Add missing "return NULL" in overflow check in PyString_Repr().
---

diff --git a/Objects/stringobject.c b/Objects/stringobject.c
index 0e3dc4f780..6673f670a0 100644
--- a/Objects/stringobject.c
+++ b/Objects/stringobject.c
@@ -861,6 +861,7 @@ PyString_Repr(PyObject *obj, int smartquotes)
 	if (newsize > PY_SSIZE_T_MAX || newsize / 4 != op->ob_size) {
 		PyErr_SetString(PyExc_OverflowError,
 			"string is too large to make repr");
+		return NULL;
 	}
 	v = PyString_FromStringAndSize((char *)NULL, newsize);
 	if (v == NULL) {