From: Xiang Zhang <angwerzx@126.com>
Date: Wed, 22 Mar 2017 04:46:14 +0000 (+0800)
Subject: bpo-29874: fix INCREF for possible NULL values in select_select() (GH-758)
X-Git-Tag: v2.7.14rc1~241
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e6a55dd8391651a7d3a97b6215e70e48e628d3d7;p=python

bpo-29874: fix INCREF for possible NULL values in select_select() (GH-758)
---

diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c
index 6ea308adb0..da03366bb9 100644
--- a/Modules/selectmodule.c
+++ b/Modules/selectmodule.c
@@ -289,9 +289,9 @@ select_select(PyObject *self, PyObject *args)
         else
             ret = PyTuple_Pack(3, ifdlist, ofdlist, efdlist);
 
-        Py_DECREF(ifdlist);
-        Py_DECREF(ofdlist);
-        Py_DECREF(efdlist);
+        Py_XDECREF(ifdlist);
+        Py_XDECREF(ofdlist);
+        Py_XDECREF(efdlist);
     }
 
   finally:
@@ -1298,7 +1298,7 @@ kqueue_event_init(kqueue_event_Object *self, PyObject *args, PyObject *kwds)
 
     if (PyLong_Check(pfd)
 #if IDENT_TYPE == T_UINT
-	&& PyLong_AsUnsignedLong(pfd) <= UINT_MAX
+        && PyLong_AsUnsignedLong(pfd) <= UINT_MAX
 #endif
     ) {
         self->e.ident = IDENT_AsType(pfd);