From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Thu, 15 Mar 2018 12:51:12 +0000 (-0300)
Subject: test_ddl_deparse: Don't use pg_class as source for a matview
X-Git-Tag: REL_11_BETA1~596
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e69f5e0efca;p=postgresql

test_ddl_deparse: Don't use pg_class as source for a matview

Doing so causes a pg_upgrade of a database containing these objects to
fail whenever pg_class changes.  And it's pointless anyway: we have more
interesting tables anyhow.

Discussion: https://postgr.es/m/CAD5tBc+s8pW9WvH2+_z=B4x95FD4QuzZKcaMpff_9H4rS0VU1A@mail.gmail.com
---

diff --git a/src/test/modules/test_ddl_deparse/expected/matviews.out b/src/test/modules/test_ddl_deparse/expected/matviews.out
index b946ff06d2..4ac2cc8325 100644
--- a/src/test/modules/test_ddl_deparse/expected/matviews.out
+++ b/src/test/modules/test_ddl_deparse/expected/matviews.out
@@ -2,7 +2,7 @@
 -- Materialized views
 --
 CREATE MATERIALIZED VIEW pg_class_mv AS
-  SELECT * FROM pg_class LIMIT 1 WITH NO DATA;
+  SELECT * FROM datatype_table LIMIT 1 WITH NO DATA;
 NOTICE:  DDL test: type simple, tag CREATE MATERIALIZED VIEW
 REFRESH MATERIALIZED VIEW pg_class_mv;
 NOTICE:  DDL test: type simple, tag REFRESH MATERIALIZED VIEW
diff --git a/src/test/modules/test_ddl_deparse/sql/matviews.sql b/src/test/modules/test_ddl_deparse/sql/matviews.sql
index 381c11e1f8..990082934e 100644
--- a/src/test/modules/test_ddl_deparse/sql/matviews.sql
+++ b/src/test/modules/test_ddl_deparse/sql/matviews.sql
@@ -3,6 +3,6 @@
 --
 
 CREATE MATERIALIZED VIEW pg_class_mv AS
-  SELECT * FROM pg_class LIMIT 1 WITH NO DATA;
+  SELECT * FROM datatype_table LIMIT 1 WITH NO DATA;
 
 REFRESH MATERIALIZED VIEW pg_class_mv;