From: Richard Russon <rich@flatcap.org>
Date: Mon, 29 Apr 2019 13:46:55 +0000 (+0100)
Subject: test: add buffer tests for degenerate cases
X-Git-Tag: 2019-10-25~233^2~81
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e69a7af6cd7f3467fda79e0be758ac43eafc848a;p=neomutt

test: add buffer tests for degenerate cases
---

diff --git a/test/buffer/mutt_buffer_add_printf.c b/test/buffer/mutt_buffer_add_printf.c
index 208a3d7fb..fa21b9381 100644
--- a/test/buffer/mutt_buffer_add_printf.c
+++ b/test/buffer/mutt_buffer_add_printf.c
@@ -28,4 +28,13 @@
 void test_mutt_buffer_add_printf(void)
 {
   // int mutt_buffer_add_printf(struct Buffer *buf, const char *fmt, ...);
+
+  {
+    TEST_CHECK(mutt_buffer_add_printf(NULL, "apple") != 0);
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    TEST_CHECK(mutt_buffer_add_printf(&buf, NULL) != 0);
+  }
 }
diff --git a/test/buffer/mutt_buffer_addch.c b/test/buffer/mutt_buffer_addch.c
index ac017552f..690c29ccc 100644
--- a/test/buffer/mutt_buffer_addch.c
+++ b/test/buffer/mutt_buffer_addch.c
@@ -28,4 +28,8 @@
 void test_mutt_buffer_addch(void)
 {
   // size_t mutt_buffer_addch(struct Buffer *buf, char c);
+
+  {
+    TEST_CHECK(mutt_buffer_addch(NULL, 'a') == 0);
+  }
 }
diff --git a/test/buffer/mutt_buffer_addstr.c b/test/buffer/mutt_buffer_addstr.c
index bb934a598..ace3a5461 100644
--- a/test/buffer/mutt_buffer_addstr.c
+++ b/test/buffer/mutt_buffer_addstr.c
@@ -28,4 +28,13 @@
 void test_mutt_buffer_addstr(void)
 {
   // size_t mutt_buffer_addstr(struct Buffer *buf, const char *s);
+
+  {
+    TEST_CHECK(mutt_buffer_addstr(NULL, "apple") == 0);
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    TEST_CHECK(mutt_buffer_addstr(&buf, NULL) == 0);
+  }
 }
diff --git a/test/buffer/mutt_buffer_addstr_n.c b/test/buffer/mutt_buffer_addstr_n.c
index 3643f1b44..2fd777d0a 100644
--- a/test/buffer/mutt_buffer_addstr_n.c
+++ b/test/buffer/mutt_buffer_addstr_n.c
@@ -28,4 +28,13 @@
 void test_mutt_buffer_addstr_n(void)
 {
   // size_t mutt_buffer_addstr_n(struct Buffer *buf, const char *s, size_t len);
+
+  {
+    TEST_CHECK(mutt_buffer_addstr_n(NULL, "apple", 10) == 0);
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    TEST_CHECK(mutt_buffer_addstr_n(&buf, NULL, 10) == 0);
+  }
 }
diff --git a/test/buffer/mutt_buffer_concat_path.c b/test/buffer/mutt_buffer_concat_path.c
index 713d26963..c52d5d247 100644
--- a/test/buffer/mutt_buffer_concat_path.c
+++ b/test/buffer/mutt_buffer_concat_path.c
@@ -28,4 +28,21 @@
 void test_mutt_buffer_concat_path(void)
 {
   // void mutt_buffer_concat_path(struct Buffer *buf, const char *dir, const char *fname);
+
+  {
+    mutt_buffer_concat_path(NULL, "apple", "banana");
+    TEST_CHECK_(1, "mutt_buffer_concat_path(NULL, \"apple\", \"banana\")");
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    mutt_buffer_concat_path(&buf, NULL, "banana");
+    TEST_CHECK_(1, "mutt_buffer_concat_path(&buf, NULL, \"banana\")");
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    mutt_buffer_concat_path(&buf, "apple", NULL);
+    TEST_CHECK_(1, "mutt_buffer_concat_path(&buf, \"apple\", NULL)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_fix_dptr.c b/test/buffer/mutt_buffer_fix_dptr.c
index 0272b2175..b0b57fb1d 100644
--- a/test/buffer/mutt_buffer_fix_dptr.c
+++ b/test/buffer/mutt_buffer_fix_dptr.c
@@ -28,4 +28,9 @@
 void test_mutt_buffer_fix_dptr(void)
 {
   // void mutt_buffer_fix_dptr(struct Buffer *buf);
+
+  {
+    mutt_buffer_fix_dptr(NULL);
+    TEST_CHECK_(1, "mutt_buffer_fix_dptr(NULL)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_free.c b/test/buffer/mutt_buffer_free.c
index c1a5b67fb..73951d24a 100644
--- a/test/buffer/mutt_buffer_free.c
+++ b/test/buffer/mutt_buffer_free.c
@@ -28,4 +28,15 @@
 void test_mutt_buffer_free(void)
 {
   // void mutt_buffer_free(struct Buffer **p);
+
+  {
+    mutt_buffer_free(NULL);
+    TEST_CHECK_(1, "mutt_buffer_free(NULL)");
+  }
+
+  {
+    struct Buffer *buf = NULL;
+    mutt_buffer_free(&buf);
+    TEST_CHECK_(1, "mutt_buffer_free(&buf)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_from.c b/test/buffer/mutt_buffer_from.c
index 55a47db80..f8df27187 100644
--- a/test/buffer/mutt_buffer_from.c
+++ b/test/buffer/mutt_buffer_from.c
@@ -28,4 +28,8 @@
 void test_mutt_buffer_from(void)
 {
   // struct Buffer *mutt_buffer_from(const char *seed);
+
+  {
+    TEST_CHECK(!mutt_buffer_from(NULL));
+  }
 }
diff --git a/test/buffer/mutt_buffer_increase_size.c b/test/buffer/mutt_buffer_increase_size.c
index d4f525198..561b16610 100644
--- a/test/buffer/mutt_buffer_increase_size.c
+++ b/test/buffer/mutt_buffer_increase_size.c
@@ -28,4 +28,9 @@
 void test_mutt_buffer_increase_size(void)
 {
   // void mutt_buffer_increase_size(struct Buffer *buf, size_t new_size);
+
+  {
+    mutt_buffer_increase_size(NULL, 10);
+    TEST_CHECK_(1, "mutt_buffer_increase_size(NULL, 10)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_init.c b/test/buffer/mutt_buffer_init.c
index eebf79ab6..cd56a5b5a 100644
--- a/test/buffer/mutt_buffer_init.c
+++ b/test/buffer/mutt_buffer_init.c
@@ -28,4 +28,8 @@
 void test_mutt_buffer_init(void)
 {
   // struct Buffer *mutt_buffer_init(struct Buffer *buf);
+
+  {
+    TEST_CHECK(!mutt_buffer_init(NULL));
+  }
 }
diff --git a/test/buffer/mutt_buffer_is_empty.c b/test/buffer/mutt_buffer_is_empty.c
index 50af33bbc..a2737aea2 100644
--- a/test/buffer/mutt_buffer_is_empty.c
+++ b/test/buffer/mutt_buffer_is_empty.c
@@ -28,4 +28,8 @@
 void test_mutt_buffer_is_empty(void)
 {
   // bool mutt_buffer_is_empty(const struct Buffer *buf);
+
+  {
+    TEST_CHECK(mutt_buffer_is_empty(NULL));
+  }
 }
diff --git a/test/buffer/mutt_buffer_len.c b/test/buffer/mutt_buffer_len.c
index 654067534..df8640753 100644
--- a/test/buffer/mutt_buffer_len.c
+++ b/test/buffer/mutt_buffer_len.c
@@ -28,4 +28,8 @@
 void test_mutt_buffer_len(void)
 {
   // size_t mutt_buffer_len(const struct Buffer *buf);
+
+  {
+    TEST_CHECK(mutt_buffer_len(NULL) == 0);
+  }
 }
diff --git a/test/buffer/mutt_buffer_pool_release.c b/test/buffer/mutt_buffer_pool_release.c
index af93000cd..a097bcd76 100644
--- a/test/buffer/mutt_buffer_pool_release.c
+++ b/test/buffer/mutt_buffer_pool_release.c
@@ -28,4 +28,15 @@
 void test_mutt_buffer_pool_release(void)
 {
   // void mutt_buffer_pool_release(struct Buffer **pbuf);
+
+  {
+    mutt_buffer_pool_release(NULL);
+    TEST_CHECK_(1, "mutt_buffer_pool_release(NULL)");
+  }
+
+  {
+    struct Buffer *buf = NULL;
+    mutt_buffer_pool_release(&buf);
+    TEST_CHECK_(1, "mutt_buffer_pool_release(&buf)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_printf.c b/test/buffer/mutt_buffer_printf.c
index 3a7873774..34907d337 100644
--- a/test/buffer/mutt_buffer_printf.c
+++ b/test/buffer/mutt_buffer_printf.c
@@ -28,4 +28,13 @@
 void test_mutt_buffer_printf(void)
 {
   // int mutt_buffer_printf(struct Buffer *buf, const char *fmt, ...);
+
+  {
+    TEST_CHECK(mutt_buffer_printf(NULL, "apple") != 0);
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    TEST_CHECK(mutt_buffer_printf(&buf, NULL) != 0);
+  }
 }
diff --git a/test/buffer/mutt_buffer_reset.c b/test/buffer/mutt_buffer_reset.c
index e5dbf456e..66bcf723b 100644
--- a/test/buffer/mutt_buffer_reset.c
+++ b/test/buffer/mutt_buffer_reset.c
@@ -28,4 +28,9 @@
 void test_mutt_buffer_reset(void)
 {
   // void mutt_buffer_reset(struct Buffer *buf);
+
+  {
+    mutt_buffer_reset(NULL);
+    TEST_CHECK_(1, "mutt_buffer_reset(NULL)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_strcpy.c b/test/buffer/mutt_buffer_strcpy.c
index 6701bc995..5b916d397 100644
--- a/test/buffer/mutt_buffer_strcpy.c
+++ b/test/buffer/mutt_buffer_strcpy.c
@@ -28,4 +28,15 @@
 void test_mutt_buffer_strcpy(void)
 {
   // void mutt_buffer_strcpy(struct Buffer *buf, const char *s);
+
+  {
+    mutt_buffer_strcpy(NULL, "apple");
+    TEST_CHECK_(1, "mutt_buffer_strcpy(NULL, \"apple\")");
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    mutt_buffer_strcpy(&buf, NULL);
+    TEST_CHECK_(1, "mutt_buffer_strcpy(&buf, NULL)");
+  }
 }
diff --git a/test/buffer/mutt_buffer_strcpy_n.c b/test/buffer/mutt_buffer_strcpy_n.c
index 2608a8244..0aaf73a5b 100644
--- a/test/buffer/mutt_buffer_strcpy_n.c
+++ b/test/buffer/mutt_buffer_strcpy_n.c
@@ -28,4 +28,15 @@
 void test_mutt_buffer_strcpy_n(void)
 {
   // void mutt_buffer_strcpy_n(struct Buffer *buf, const char *s, size_t len);
+
+  {
+    mutt_buffer_strcpy_n(NULL, "apple", 3);
+    TEST_CHECK_(1, "mutt_buffer_strcpy_n(NULL, \"apple\", 3)");
+  }
+
+  {
+    struct Buffer buf = { 0 };
+    mutt_buffer_strcpy_n(&buf, NULL, 3);
+    TEST_CHECK_(1, "mutt_buffer_strcpy_n(&buf, NULL, 3)");
+  }
 }