From: Matt Arsenault Date: Fri, 17 Feb 2017 00:32:19 +0000 (+0000) Subject: Bug 31948: Fix assertion when bitcasting constantexpr pointers X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e67c4a1dbe7167b4a5f7782e8e64c6ecce428ecc;p=llvm Bug 31948: Fix assertion when bitcasting constantexpr pointers git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295387 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InferAddressSpaces.cpp b/lib/Transforms/Scalar/InferAddressSpaces.cpp index 8e1e0374576..96da4bf2e0d 100644 --- a/lib/Transforms/Scalar/InferAddressSpaces.cpp +++ b/lib/Transforms/Scalar/InferAddressSpaces.cpp @@ -448,6 +448,12 @@ static Value *cloneConstantExprWithNewAddressSpace( return ConstantExpr::getBitCast(CE->getOperand(0), TargetType); } + if (CE->getOpcode() == Instruction::BitCast) { + if (Value *NewOperand = ValueWithNewAddrSpace.lookup(CE->getOperand(0))) + return ConstantExpr::getBitCast(cast(NewOperand), TargetType); + return ConstantExpr::getAddrSpaceCast(CE, TargetType); + } + if (CE->getOpcode() == Instruction::Select) { Constant *Src0 = CE->getOperand(1); Constant *Src1 = CE->getOperand(2); diff --git a/test/Transforms/InferAddressSpaces/lit.local.cfg b/test/Transforms/InferAddressSpaces/AMDGPU/lit.local.cfg similarity index 100% rename from test/Transforms/InferAddressSpaces/lit.local.cfg rename to test/Transforms/InferAddressSpaces/AMDGPU/lit.local.cfg diff --git a/test/Transforms/InferAddressSpaces/NVPTX/bug31948.ll b/test/Transforms/InferAddressSpaces/NVPTX/bug31948.ll new file mode 100644 index 00000000000..b2d8ddb1956 --- /dev/null +++ b/test/Transforms/InferAddressSpaces/NVPTX/bug31948.ll @@ -0,0 +1,24 @@ +; RUN: opt -S -mtriple=nvptx64-nvidia-cuda -infer-address-spaces %s | FileCheck %s + +target datalayout = "e-i64:64-v16:16-v32:32-n16:32:64" + +%struct.bar = type { float, float* } + +@var1 = local_unnamed_addr addrspace(3) externally_initialized global %struct.bar undef, align 8 + +; CHECK-LABEL: @bug31948( +; CHECK: %tmp = load float*, float* addrspace(3)* getelementptr inbounds (%struct.bar, %struct.bar addrspace(3)* @var1, i64 0, i32 1), align 8 +; CHECK: %tmp1 = load float, float* %tmp, align 4 +; CHECK: store float %conv1, float* %tmp, align 4 +; CHECK: store i32 32, i32 addrspace(3)* addrspacecast (i32* bitcast (float** getelementptr (%struct.bar, %struct.bar* addrspacecast (%struct.bar addrspace(3)* @var1 to %struct.bar*), i64 0, i32 1) to i32*) to i32 addrspace(3)*), align 4 +define void @bug31948(float %a, float* nocapture readnone %x, float* nocapture readnone %y) local_unnamed_addr #0 { +entry: + %tmp = load float*, float** getelementptr (%struct.bar, %struct.bar* addrspacecast (%struct.bar addrspace(3)* @var1 to %struct.bar*), i64 0, i32 1), align 8 + %tmp1 = load float, float* %tmp, align 4 + %conv1 = fadd float %tmp1, 1.000000e+00 + store float %conv1, float* %tmp, align 4 + store i32 32, i32* bitcast (float** getelementptr (%struct.bar, %struct.bar* addrspacecast (%struct.bar addrspace(3)* @var1 to %struct.bar*), i64 0, i32 1) to i32*), align 4 + ret void +} + +attributes #0 = { norecurse nounwind } diff --git a/test/Transforms/InferAddressSpaces/NVPTX/lit.local.cfg b/test/Transforms/InferAddressSpaces/NVPTX/lit.local.cfg new file mode 100644 index 00000000000..2cb98eb371b --- /dev/null +++ b/test/Transforms/InferAddressSpaces/NVPTX/lit.local.cfg @@ -0,0 +1,2 @@ +if not 'NVPTX' in config.root.targets: + config.unsupported = True