From: nhmall <nhmall@nethack.org>
Date: Mon, 20 May 2019 03:35:21 +0000 (-0400)
Subject: fix a botl status display issue
X-Git-Tag: nmake-explicit-path~2^2~121
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e65386883339afd86a633fab3022cd2e01459a94;p=nethack

fix a botl status display issue

Reported as #H8609 (1679)

Some code recently added to render_status() for BL_CONDITION:
    if (!tty_condition_bits)
        continue;
was short-circuiting the required copy of NOW
values to BEFORE values for later comparison
further down in the for-loop.
    tty_status[BEFORE][idx] = tty_status[NOW][idx];

This caused some fields to be bypassed for rendering
once no more tty_condition_bits were set because the
length comparisons would match.
---

diff --git a/doc/fixes36.3 b/doc/fixes36.3
index 8d5c22376..871143897 100644
--- a/doc/fixes36.3
+++ b/doc/fixes36.3
@@ -16,6 +16,8 @@ when examining the map with '/' or ';', picking a symbol which is used for
 billing and payment issue as a result of glob coalescing
 glob pricing did not consider weight properly
 glob shop interaction improved to handle more of the expected scenarios
+remove the for-loop short circuit in render_status() that was preventing
+	the copy of BL_CONDITION tty_status values from NOW to BEFORE
 
 
 Fixes to Post-3.6.2 Problems that Were Exposed Via git Repository
diff --git a/win/tty/wintty.c b/win/tty/wintty.c
index cc191fb65..831e5326b 100644
--- a/win/tty/wintty.c
+++ b/win/tty/wintty.c
@@ -4345,8 +4345,6 @@ render_status(VOID_ARGS)
                      * | Condition Codes |
                      * +-----------------+
                      */
-                    if (!tty_condition_bits)
-                        continue;
                     if (num_rows == 3) {
                         int k;
                         char *dat = &cw->data[y][0];