From: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Fri, 17 Mar 2017 19:54:50 +0000 (+0000)
Subject: bpo-29808: Do not fail in SysLogHandler constructor if syslog isn't available. (... 
X-Git-Tag: v3.5.4rc1~270
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e59af55c28b657cdf57c71a7b0837c9e9f4b2a31;p=python

bpo-29808: Do not fail in SysLogHandler constructor if syslog isn't available. (#695)

bpo-29808: SysLogHandler: Do not fail if initial connect to syslog failed.

(cherry picked from commit 1b038e073807ecb6fd176edaf3386a8e3205416e)
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index c39a56ff06..e3463312f9 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -803,7 +803,14 @@ class SysLogHandler(logging.Handler):
 
         if isinstance(address, str):
             self.unixsocket = True
-            self._connect_unixsocket(address)
+            # Syslog server may be unavailable during handler initialisation.
+            # C's openlog() function also ignores connection errors.
+            # Moreover, we ignore these errors while logging, so it not worse
+            # to ignore it also here.
+            try:
+                self._connect_unixsocket(address)
+            except OSError:
+                pass
         else:
             self.unixsocket = False
             if socktype is None: