From: Nick Coghlan <ncoghlan@gmail.com>
Date: Sun, 17 Jun 2012 11:15:45 +0000 (+1000)
Subject: Merge from 3.2 (Issue #15095: Use better assertions in test_imaplib)
X-Git-Tag: v3.3.0b1~205
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e51e25a3bc6e4e8396ebf63c78f269fabae0f0d0;p=python

Merge from 3.2 (Issue #15095: Use better assertions in test_imaplib)
---

e51e25a3bc6e4e8396ebf63c78f269fabae0f0d0
diff --cc Lib/test/test_imaplib.py
index 50b2da10df,5c99a58570..e629cb1f66
--- a/Lib/test/test_imaplib.py
+++ b/Lib/test/test_imaplib.py
@@@ -265,58 -265,11 +265,58 @@@ class RemoteIMAP_SSLTest(RemoteIMAPTest
      port = 993
      imap_class = IMAP4_SSL
  
 +    def setUp(self):
 +        pass
 +
 +    def tearDown(self):
 +        pass
 +
 +    def create_ssl_context(self):
 +        ssl_context = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
 +        ssl_context.load_cert_chain(CERTFILE)
 +        return ssl_context
 +
 +    def check_logincapa(self, server):
 +        try:
 +            for cap in server.capabilities:
 +                self.assertIsInstance(cap, str)
-             self.assertFalse('LOGINDISABLED' in server.capabilities)
-             self.assertTrue('AUTH=PLAIN' in server.capabilities)
++            self.assertNotIn('LOGINDISABLED', server.capabilities)
++            self.assertIn('AUTH=PLAIN', server.capabilities)
 +            rs = server.login(self.username, self.password)
 +            self.assertEqual(rs[0], 'OK')
 +        finally:
 +            server.logout()
 +
      def test_logincapa(self):
 -        for cap in self.server.capabilities:
 -            self.assertIsInstance(cap, str)
 -        self.assertNotIn('LOGINDISABLED', self.server.capabilities)
 -        self.assertIn('AUTH=PLAIN', self.server.capabilities)
 +        with transient_internet(self.host):
 +            _server = self.imap_class(self.host, self.port)
 +            self.check_logincapa(_server)
 +
 +    def test_logincapa_with_client_certfile(self):
 +        with transient_internet(self.host):
 +            _server = self.imap_class(self.host, self.port, certfile=CERTFILE)
 +            self.check_logincapa(_server)
 +
 +    def test_logincapa_with_client_ssl_context(self):
 +        with transient_internet(self.host):
 +            _server = self.imap_class(self.host, self.port, ssl_context=self.create_ssl_context())
 +            self.check_logincapa(_server)
 +
 +    def test_logout(self):
 +        with transient_internet(self.host):
 +            _server = self.imap_class(self.host, self.port)
 +            rs = _server.logout()
 +            self.assertEqual(rs[0], 'BYE')
 +
 +    def test_ssl_context_certfile_exclusive(self):
 +        with transient_internet(self.host):
 +            self.assertRaises(ValueError, self.imap_class, self.host, self.port,
 +                              certfile=CERTFILE, ssl_context=self.create_ssl_context())
 +
 +    def test_ssl_context_keyfile_exclusive(self):
 +        with transient_internet(self.host):
 +            self.assertRaises(ValueError, self.imap_class, self.host, self.port,
 +                              keyfile=CERTFILE, ssl_context=self.create_ssl_context())
  
  
  def test_main():