From: Joe Conway <mail@joeconway.com>
Date: Sat, 3 Jan 2009 19:58:10 +0000 (+0000)
Subject: Fix bug per Oleksiy Shchukin - 2nd argument for dblink_get_result(text,bool)
X-Git-Tag: REL8_2_12~16
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e4dcb11ead8f4109f2b97aaef93807f1fcba818f;p=postgresql

Fix bug per Oleksiy Shchukin - 2nd argument for dblink_get_result(text,bool)
is PG_GETARG_BOOL(2), should be PG_GETARG_BOOL(1).

Apply simple fix to back branches only. More extensive change to be applied
to head per Tom's suggestion.
---

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 9cd3a27004..609126b74b 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -8,7 +8,7 @@
  * Darko Prenosil <Darko.Prenosil@finteh.hr>
  * Shridhar Daithankar <shridhar_daithankar@persistent.co.in>
  *
- * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.60.2.3 2008/11/30 23:24:08 tgl Exp $
+ * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.60.2.4 2009/01/03 19:58:10 joe Exp $
  * Copyright (c) 2001-2006, PostgreSQL Global Development Group
  * ALL RIGHTS RESERVED;
  *
@@ -806,7 +806,7 @@ dblink_record_internal(FunctionCallInfo fcinfo, bool is_async, bool do_get)
 			{
 				/* text,bool */
 				DBLINK_GET_CONN;
-				fail = PG_GETARG_BOOL(2);
+				fail = PG_GETARG_BOOL(1);
 			}
 			else if (PG_NARGS() == 1)
 			{