From: Richard Russon <rich@flatcap.org>
Date: Tue, 20 Aug 2019 19:29:26 +0000 (+0100)
Subject: rename mutt_menu_destroy()
X-Git-Tag: 2019-10-25~91^2~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e4cc966ea3b76f27b97b380c610d406b59d3e3be;p=neomutt

rename mutt_menu_destroy()

All the other free functions are called *_free().
---

diff --git a/addrbook.c b/addrbook.c
index 3635620cf..38518c729 100644
--- a/addrbook.c
+++ b/addrbook.c
@@ -308,6 +308,6 @@ new_aliases:
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   FREE(&alias_table);
 }
diff --git a/autocrypt/autocrypt_acct_menu.c b/autocrypt/autocrypt_acct_menu.c
index 289a911a0..fa827c349 100644
--- a/autocrypt/autocrypt_acct_menu.c
+++ b/autocrypt/autocrypt_acct_menu.c
@@ -224,7 +224,7 @@ static void free_menu(struct Menu **menu)
 
   mutt_menu_pop_current(*menu);
   FREE(&(*menu)->help);
-  mutt_menu_destroy(menu);
+  mutt_menu_free(menu);
 }
 
 /**
diff --git a/browser.c b/browser.c
index db6602b52..cac8dfb34 100644
--- a/browser.c
+++ b/browser.c
@@ -2161,7 +2161,7 @@ bail:
   if (menu)
   {
     mutt_menu_pop_current(menu);
-    mutt_menu_destroy(&menu);
+    mutt_menu_free(&menu);
   }
 
   if (goto_swapper[0] != '\0')
diff --git a/compose.c b/compose.c
index fc6bd8230..97cb8e0b3 100644
--- a/compose.c
+++ b/compose.c
@@ -2187,7 +2187,7 @@ int mutt_compose_menu(struct Email *e, char *fcc, size_t fcclen, struct Email *e
 #endif
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
 
   if (actx->idxlen)
     e->content = actx->idx[0]->content;
diff --git a/conn/ssl.c b/conn/ssl.c
index cb465926d..3af188701 100644
--- a/conn/ssl.c
+++ b/conn/ssl.c
@@ -1040,7 +1040,7 @@ static bool interactive_check_cert(X509 *cert, int idx, size_t len, SSL *ssl, bo
 
   mutt_buffer_pool_release(&drow);
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   mutt_debug(LL_DEBUG2, "done=%d\n", done);
   return done == 2;
 }
diff --git a/conn/ssl_gnutls.c b/conn/ssl_gnutls.c
index 6effa72ba..fa0846b90 100644
--- a/conn/ssl_gnutls.c
+++ b/conn/ssl_gnutls.c
@@ -743,7 +743,7 @@ static int tls_check_one_certificate(const gnutls_datum_t *certdata,
 
   mutt_buffer_pool_release(&drow);
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   gnutls_x509_crt_deinit(cert);
 
   return done == 2;
diff --git a/index.c b/index.c
index 96e39f330..f306b4cbf 100644
--- a/index.c
+++ b/index.c
@@ -3660,7 +3660,7 @@ int mutt_index_menu(void)
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   return close;
 }
 
diff --git a/menu.c b/menu.c
index 717fd8071..ebebb37f5 100644
--- a/menu.c
+++ b/menu.c
@@ -997,20 +997,24 @@ struct Menu *mutt_menu_new(enum MenuType type)
 }
 
 /**
- * mutt_menu_destroy - Destroy a menu
+ * mutt_menu_free - Destroy a menu
  * @param[out] p Menu to destroy
  */
-void mutt_menu_destroy(struct Menu **p)
+void mutt_menu_free(struct Menu **ptr)
 {
-  if ((*p)->dialog)
+  if (!ptr || !*ptr)
+    return;
+
+  struct Menu *m = *ptr;
+  if (m->dialog)
   {
-    for (int i = 0; i < (*p)->max; i++)
-      FREE(&(*p)->dialog[i]);
+    for (int i = 0; i < m->max; i++)
+      FREE(&m->dialog[i]);
 
-    FREE(&(*p)->dialog);
+    FREE(&m->dialog);
   }
 
-  FREE(p);
+  FREE(ptr);
 }
 
 /**
diff --git a/mutt_history.c b/mutt_history.c
index 51ec6d59a..bb68fac1c 100644
--- a/mutt_history.c
+++ b/mutt_history.c
@@ -122,7 +122,7 @@ static void history_menu(char *buf, size_t buflen, char **matches, int match_cou
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
 }
 
 /**
diff --git a/mutt_menu.h b/mutt_menu.h
index afe9f265f..cc6ae72b4 100644
--- a/mutt_menu.h
+++ b/mutt_menu.h
@@ -178,7 +178,7 @@ int          menu_redraw(struct Menu *menu);
 void         menu_top_page(struct Menu *menu);
 void         mutt_menu_add_dialog_row(struct Menu *menu, const char *row);
 void         mutt_menu_current_redraw(void);
-void         mutt_menu_destroy(struct Menu **p);
+void         mutt_menu_free(struct Menu **ptr);
 void         mutt_menu_init(void);
 int          mutt_menu_loop(struct Menu *menu);
 struct Menu *mutt_menu_new(enum MenuType type);
diff --git a/ncrypt/crypt_gpgme.c b/ncrypt/crypt_gpgme.c
index de5ea695b..a7eec38cf 100644
--- a/ncrypt/crypt_gpgme.c
+++ b/ncrypt/crypt_gpgme.c
@@ -4887,7 +4887,7 @@ static struct CryptKeyInfo *crypt_select_key(struct CryptKeyInfo *keys,
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   FREE(&key_table);
 
   return k;
diff --git a/ncrypt/pgpkey.c b/ncrypt/pgpkey.c
index c108b1d3a..60bb21c64 100644
--- a/ncrypt/pgpkey.c
+++ b/ncrypt/pgpkey.c
@@ -802,7 +802,7 @@ static struct PgpKeyInfo *pgp_select_key(struct PgpKeyInfo *keys,
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   FREE(&key_table);
 
   return kp;
diff --git a/ncrypt/smime.c b/ncrypt/smime.c
index 59004dcfe..5c567418e 100644
--- a/ncrypt/smime.c
+++ b/ncrypt/smime.c
@@ -611,7 +611,7 @@ static struct SmimeKey *smime_select_key(struct SmimeKey *keys, char *query)
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   FREE(&table);
 
   return selected_key;
diff --git a/pager.c b/pager.c
index a5daf6862..3f0542ef3 100644
--- a/pager.c
+++ b/pager.c
@@ -3109,7 +3109,7 @@ int mutt_pager(const char *banner, const char *fname, PagerFlags flags, struct P
         if (old_PagerIndexLines != C_PagerIndexLines)
         {
           if (rd.index)
-            mutt_menu_destroy(&rd.index);
+            mutt_menu_free(&rd.index);
           rd.index = NULL;
         }
 
@@ -3581,9 +3581,9 @@ int mutt_pager(const char *banner, const char *fname, PagerFlags flags, struct P
   }
   FREE(&rd.line_info);
   mutt_menu_pop_current(pager_menu);
-  mutt_menu_destroy(&pager_menu);
+  mutt_menu_free(&pager_menu);
   if (rd.index)
-    mutt_menu_destroy(&rd.index);
+    mutt_menu_free(&rd.index);
 
   mutt_buffer_free(&helpstr);
   mutt_window_free(&rd.index_status_window);
diff --git a/postpone.c b/postpone.c
index 25901f41d..295f1f892 100644
--- a/postpone.c
+++ b/postpone.c
@@ -272,7 +272,7 @@ static struct Email *select_msg(struct Context *ctx)
 
   C_Sort = orig_sort;
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
   return (r > -1) ? ctx->mailbox->emails[r] : NULL;
 }
 
diff --git a/query.c b/query.c
index 9150cd152..2ed340f94 100644
--- a/query.c
+++ b/query.c
@@ -420,7 +420,7 @@ static void query_menu(char *buf, size_t buflen, struct Query *results, bool ret
 
               menu->current = 0;
               mutt_menu_pop_current(menu);
-              mutt_menu_destroy(&menu);
+              mutt_menu_free(&menu);
               menu = mutt_menu_new(MENU_QUERY);
               menu->menu_make_entry = query_make_entry;
               menu->menu_search = query_search;
@@ -600,7 +600,7 @@ static void query_menu(char *buf, size_t buflen, struct Query *results, bool ret
     free_query(&results);
     FREE(&query_table);
     mutt_menu_pop_current(menu);
-    mutt_menu_destroy(&menu);
+    mutt_menu_free(&menu);
   }
 }
 
diff --git a/recvattach.c b/recvattach.c
index e82be9d76..58ef31940 100644
--- a/recvattach.c
+++ b/recvattach.c
@@ -1696,7 +1696,7 @@ void mutt_view_attachments(struct Email *e)
         mutt_actx_free(&actx);
 
         mutt_menu_pop_current(menu);
-        mutt_menu_destroy(&menu);
+        mutt_menu_free(&menu);
         return;
     }
 
diff --git a/remailer.c b/remailer.c
index cd42058d1..a87290bfb 100644
--- a/remailer.c
+++ b/remailer.c
@@ -744,7 +744,7 @@ void mix_make_chain(struct ListHead *chainhead)
   }
 
   mutt_menu_pop_current(menu);
-  mutt_menu_destroy(&menu);
+  mutt_menu_free(&menu);
 
   /* construct the remailer list */