From: Matt Caswell <matt@openssl.org>
Date: Mon, 8 Jun 2015 08:29:56 +0000 (+0100)
Subject: Fix leak in HMAC error path
X-Git-Tag: OpenSSL_1_1_0-pre1~1008
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e43a13c807e42688c72c4f3d001112bf0a110464;p=openssl

Fix leak in HMAC error path

In the event of an error in the HMAC function, leaks can occur because the
HMAC_CTX does not get cleaned up.

Thanks to the BoringSSL project for reporting this issue.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/hmac/hmac.c b/crypto/hmac/hmac.c
index 572393e2c7..d50fabb7c1 100644
--- a/crypto/hmac/hmac.c
+++ b/crypto/hmac/hmac.c
@@ -219,6 +219,7 @@ unsigned char *HMAC(const EVP_MD *evp_md, const void *key, int key_len,
     HMAC_CTX_cleanup(&c);
     return md;
  err:
+    HMAC_CTX_cleanup(&c);
     return NULL;
 }