From: Grigori Goronzy <greg@chown.ath.cx>
Date: Sun, 7 Jun 2015 19:30:41 +0000 (+0200)
Subject: Fix minor memory leak in ass_read_styles
X-Git-Tag: 0.12.3~8^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e3a13c72f6f70f12a314a67da5540691a079d5b7;p=libass

Fix minor memory leak in ass_read_styles

Reported by clang scan-build static analysis. Also fix incorrect
return value in case of error.
---

diff --git a/libass/ass.c b/libass/ass.c
index c9855ea..6e9f2fe 100644
--- a/libass/ass.c
+++ b/libass/ass.c
@@ -1229,12 +1229,13 @@ int ass_read_styles(ASS_Track *track, char *fname, char *codepage)
         buf = tmpbuf;
     }
     if (!buf)
-        return 0;
+        return 1;
 #endif
 
     old_state = track->parser_priv->state;
     track->parser_priv->state = PST_STYLES;
     process_text(track, buf);
+    free(buf);
     track->parser_priv->state = old_state;
 
     return 0;