From: Jeff King Date: Mon, 5 Oct 2015 03:43:14 +0000 (-0400) Subject: precompose_utf8: drop unused variable X-Git-Tag: v2.7.0-rc0~87^2~29 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e2b021eb5b5ce2f4be3c10f1f8063981b1a53053;p=git precompose_utf8: drop unused variable The result of iconv is assigned to a variable, but we never use it (instead, we check errno and whether the function consumed all bytes). Let's drop the assignment, as it triggers gcc's -Wunused-but-set-variable. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/compat/precompose_utf8.c b/compat/precompose_utf8.c index 95fe849e42..044c68617b 100644 --- a/compat/precompose_utf8.c +++ b/compat/precompose_utf8.c @@ -139,9 +139,8 @@ struct dirent_prec_psx *precompose_utf8_readdir(PREC_DIR *prec_dir) size_t inleft = namelenz; char *outpos = &prec_dir->dirent_nfc->d_name[0]; size_t outsz = prec_dir->dirent_nfc->max_name_len; - size_t cnt; errno = 0; - cnt = iconv(prec_dir->ic_precompose, &cp, &inleft, &outpos, &outsz); + iconv(prec_dir->ic_precompose, &cp, &inleft, &outpos, &outsz); if (errno || inleft) { /* * iconv() failed and errno could be E2BIG, EILSEQ, EINVAL, EBADF