From: Daniel Dunbar <daniel@zuster.org>
Date: Wed, 18 Mar 2009 03:02:22 +0000 (+0000)
Subject: Driver: I was too hasty in free'ing Actions, we sometimes share
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e29cd6f24689e670730623f012586234527f6dc9;p=clang

Driver: I was too hasty in free'ing Actions, we sometimes share
Actions so a simple tree traversal isn't quite good enough. Leaving a
FIXME for now.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@67161 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Driver/Action.cpp b/lib/Driver/Action.cpp
index 71bf22ffa1..cabc33eaec 100644
--- a/lib/Driver/Action.cpp
+++ b/lib/Driver/Action.cpp
@@ -13,9 +13,8 @@
 using namespace clang::driver;
 
 Action::~Action() {
-  // Free the inputs.
-  for (iterator it = begin(), ie = end(); it != ie; ++it)
-    delete *it;  
+  // FIXME: Free the inputs. The problem is that BindArchAction shares
+  // inputs; so we can't just walk the inputs.
 }
 
 const char *Action::getClassName(ActionClass AC) {