From: Jeff King <peff@peff.net>
Date: Fri, 29 May 2015 07:25:45 +0000 (-0400)
Subject: Makefile: drop dependency between git-instaweb and gitweb
X-Git-Tag: v2.4.5~2^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e25c7cc146177a59f31ca07cdd094e0566e1e4be;p=git

Makefile: drop dependency between git-instaweb and gitweb

The rule for "git-instaweb" depends on "gitweb". This makes
no sense, because:

  1. git-instaweb has no build-time dependency on gitweb; it
     is a run-time dependency

  2. gitweb is a directory that we want to recursively make
     in. As a result, its recipe is marked .PHONY, which
     causes "make" to rebuild git-instaweb every time it is
     run.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/Makefile b/Makefile
index 7482a4dbab..acb2817f02 100644
--- a/Makefile
+++ b/Makefile
@@ -1722,7 +1722,7 @@ GIT-PERL-DEFINES: FORCE
 gitweb:
 	$(QUIET_SUBDIR0)gitweb $(QUIET_SUBDIR1) all
 
-git-instaweb: git-instaweb.sh gitweb GIT-SCRIPT-DEFINES
+git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES
 	$(QUIET_GEN)$(cmd_munge_script) && \
 	chmod +x $@+ && \
 	mv $@+ $@