From: Bram Moolenaar <Bram@vim.org>
Date: Sat, 24 Oct 2020 11:30:51 +0000 (+0200)
Subject: patch 8.2.1896: valgrind warns for using uninitialized memory
X-Git-Tag: v8.2.1896
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e1be11864d1f4383171e3af3eb77e61d41140c4e;p=vim

patch 8.2.1896: valgrind warns for using uninitialized memory

Problem:    Valgrind warns for using uninitialized memory.
Solution:   NUL terminate the SmcOpenConnection() error message. (Dominique
            Pellé, closes #7194)
---

diff --git a/src/os_unix.c b/src/os_unix.c
index 40df6b727..27a88823f 100644
--- a/src/os_unix.c
+++ b/src/os_unix.c
@@ -8068,10 +8068,13 @@ xsmp_init(void)
 	    errorstring);
     if (xsmp.smcconn == NULL)
     {
-	char errorreport[132];
-
 	if (p_verbose > 0)
 	{
+	    char errorreport[132];
+
+	    // If the message is too long it might not be NUL terminated.  Add
+	    // a NUL at the end to make sure we don't go over the end.
+	    errorstring[sizeof(errorstring) - 1] = NUL;
 	    vim_snprintf(errorreport, sizeof(errorreport),
 			 _("XSMP SmcOpenConnection failed: %s"), errorstring);
 	    verb_msg(errorreport);
diff --git a/src/version.c b/src/version.c
index e445117bc..a1ee33e1a 100644
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1896,
 /**/
     1895,
 /**/