From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Mon, 12 May 2014 07:17:40 +0000 (+0300)
Subject: Free PQresult on error in pg_receivexlog.
X-Git-Tag: REL9_2_9~52
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e158bbb6e95afde040debf3f573fc9b60dbcf469;p=postgresql

Free PQresult on error in pg_receivexlog.

The leak is fairly small and rare, but a leak nevertheless.

Per Coverity report. Backpatch to 9.2, where pg_receivexlog was added.
pg_basebackup shares the code, but it always exits on error, so there is
no real leak.
---

diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index a7a79e824a..3a46767417 100644
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -612,6 +612,7 @@ ReceiveXlogStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,
 		fprintf(stderr,
 				_("%s: unexpected termination of replication stream: %s"),
 				progname, PQresultErrorMessage(res));
+		PQclear(res);
 		goto error;
 	}
 	PQclear(res);