From: Brett Cannon <bcannon@gmail.com>
Date: Fri, 4 Feb 2011 20:24:02 +0000 (+0000)
Subject: There was a possibility that the initialization of _sqlite, when it failed,
X-Git-Tag: v3.2rc3~54
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e144507b0983399fb3dbcf6535cfbead22a6c5e4;p=python

There was a possibility that the initialization of _sqlite, when it failed,
would lead to a decref of a NULL.

Fixes issue #11110.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 5df056d827..efb84882ec 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -15,6 +15,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #11110: Fix a potential decref of a NULL in sqlite3.
+
 - Issue #8275: Fix passing of callback arguments with ctypes under Win64.
   Patch by Stan Mihai.
 
diff --git a/Modules/_sqlite/module.c b/Modules/_sqlite/module.c
index 3292daee83..cbc3b8e90b 100644
--- a/Modules/_sqlite/module.c
+++ b/Modules/_sqlite/module.c
@@ -329,7 +329,7 @@ PyMODINIT_FUNC PyInit__sqlite3(void)
         (pysqlite_statement_setup_types() < 0) ||
         (pysqlite_prepare_protocol_setup_types() < 0)
        ) {
-        Py_DECREF(module);
+        Py_XDECREF(module);
         return NULL;
     }