From: R. David Murray <rdmurray@bitdance.com>
Date: Sat, 17 Apr 2010 05:26:26 +0000 (+0000)
Subject: Issue #3864: Skip three test_signal tests on freebsd6 due to platform bug.
X-Git-Tag: v2.7b2~264
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e0e8a87d7e58d1205cc727cc513cc21b045bb088;p=python

Issue #3864: Skip three test_signal tests on freebsd6 due to platform bug.

Two itimer tests and an interprocess signal test fail on FreeBSD 6 if
any test that starts a thread runs before test_signal.  Since FreeBSD7
does not show this behavior, the bug is most likely a platform bug,
so this patch just skips the failing tests on freebsd6.
---

diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
index 466b9b6256..23b0553cb8 100644
--- a/Lib/test/test_signal.py
+++ b/Lib/test/test_signal.py
@@ -139,6 +139,10 @@ class InterProcessSignalTests(unittest.TestCase):
             self.fail("pause returned of its own accord, and the signal"
                       " didn't arrive after another second.")
 
+    # Unknown if this affects earlier versions of freebsd also
+    @unittest.skipIf(sys.platform=='freebsd6',
+        'inter process signals not reliable (do not mix well with threading) '
+        'on freebsd6')
     def test_main(self):
         # This function spawns a child process to insulate the main
         # test-running process from all the signals. It then
@@ -355,6 +359,9 @@ class ItimerTest(unittest.TestCase):
 
         self.assertEqual(self.hndl_called, True)
 
+    # Unknown if this affects earlier versions of freebsd also
+    @unittest.skipIf(sys.platform=='freebsd6',
+        'itimer not reliable (does not mix well with threading) on freebsd6')
     def test_itimer_virtual(self):
         self.itimer = signal.ITIMER_VIRTUAL
         signal.signal(signal.SIGVTALRM, self.sig_vtalrm)
@@ -376,6 +383,9 @@ class ItimerTest(unittest.TestCase):
         # and the handler should have been called
         self.assertEquals(self.hndl_called, True)
 
+    # Unknown if this affects earlier versions of freebsd also
+    @unittest.skipIf(sys.platform=='freebsd6',
+        'itimer not reliable (does not mix well with threading) on freebsd6')
     def test_itimer_prof(self):
         self.itimer = signal.ITIMER_PROF
         signal.signal(signal.SIGPROF, self.sig_prof)
diff --git a/Misc/NEWS b/Misc/NEWS
index b53beab888..9f1cba17ad 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -294,6 +294,9 @@ C-API
 Tests
 -----
 
+- Issue #3864: Skip three test_signal tests on freebsd6 because they fail
+  if any thread was previously started, most likely due to a platform bug.
+
 - Issue #8348: Fix test ftp url in test_urllib2net.
 
 - Issue #8204: Fix test_ttk notebook test by forcing focus.