From: Magnus Jacobsson <Magnus.Jacobsson@berotec.se>
Date: Tue, 12 Jul 2022 13:52:26 +0000 (+0200)
Subject: add new test test_subgraph_layout
X-Git-Tag: 5.0.1~31^2~8
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e0b992c0e0cf55ce21beca49fe050a7486f8a5eb;p=graphviz

add new test test_subgraph_layout

This test is run in CI with ASan leak detection enabled. It currectly
fails because ASan detects several memory issues in various layout
engines.
---

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 5d0fcf214..3aa2d52fa 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -75,4 +75,6 @@ CREATE_TEST(GVLayout_construction)
 CREATE_TEST(GVLayout_render)
 CREATE_TEST(neatopack)
 CREATE_TEST(simple)
+CREATE_TEST(subgraph_layout)
+set_tests_properties(test_subgraph_layout PROPERTIES WILL_FAIL true)
 CREATE_TEST(subgraphs)
diff --git a/tests/test_subgraph_layout.cpp b/tests/test_subgraph_layout.cpp
new file mode 100644
index 000000000..2039ef0d2
--- /dev/null
+++ b/tests/test_subgraph_layout.cpp
@@ -0,0 +1,94 @@
+#include <string>
+
+#include <catch2/catch.hpp>
+#include <fmt/format.h>
+
+#include <cgraph/cgraph.h>
+#include <gvc/gvc.h>
+
+#include "svg_analyzer.h"
+
+TEST_CASE("subgraph layout in directed and undirected graphs with different "
+          "layout engines") {
+  const auto directed_graph = GENERATE(false, true);
+
+  const std::string graph_type = directed_graph ? "digraph" : "graph";
+  const std::string edge_op = directed_graph ? "->" : "--";
+
+  const auto num_subgraphs = GENERATE(1, 2);
+
+  const std::string dot =
+      num_subgraphs == 1
+          ? fmt::format("{} {{subgraph s0 {{a {} b}}}}", graph_type, edge_op)
+          : fmt::format(
+                "{} {{subgraph s0 {{a {} b}}; subgraph s1 {{c {} d }}}}",
+                graph_type, edge_op, edge_op);
+  INFO(fmt::format("DOT source: {}", dot));
+
+  auto g = agmemread(dot.c_str());
+  REQUIRE(g != nullptr);
+
+  const std::string engine = GENERATE("dot",      //
+                                      "neato",    //
+                                      "fdp",      //
+                                      "sfdp",     //
+                                      "circo",    //
+                                      "twopi",    //
+                                      "osage",    //
+                                      "patchwork" //
+  );
+  INFO("Layout engine: " + engine);
+
+  auto gvc = gvContextPlugins(lt_preloaded_symbols, false);
+
+  for (Agraph_t *subg = agfstsubg(g); subg; subg = agnxtsubg(subg)) {
+    {
+      const auto rc = gvLayout(gvc, subg, engine.c_str());
+      REQUIRE(rc == 0);
+    }
+
+    char *result = nullptr;
+    unsigned length = 0;
+    {
+      const auto rc = gvRenderData(gvc, subg, "svg", &result, &length);
+      REQUIRE(rc == 0);
+    }
+    REQUIRE(result != nullptr);
+    REQUIRE(length > 0);
+
+    SVGAnalyzer svg_analyzer{result};
+
+    const std::size_t num_nodes = 2;
+    const std::size_t num_edges = engine == "patchwork" ? 0 : 1;
+    const std::size_t num_arrowheads = directed_graph ? num_edges : 0;
+
+    const std::size_t num_svgs = 1;
+    const std::size_t num_groups = 1 + num_nodes + num_edges;
+    const std::size_t num_ellipses = engine == "patchwork" ? 0 : num_nodes;
+    const std::size_t num_polygons =
+        1 + (engine == "patchwork" ? num_nodes : 0) + num_arrowheads;
+    const std::size_t num_paths = num_edges;
+    const std::size_t num_titles = 1 + num_nodes + num_edges;
+
+    CHECK(svg_analyzer.num_svgs() == num_svgs);
+    CHECK(svg_analyzer.num_groups() == num_groups);
+    CHECK(svg_analyzer.num_circles() == 0);
+    CHECK(svg_analyzer.num_ellipses() == num_ellipses);
+    CHECK(svg_analyzer.num_lines() == 0);
+    CHECK(svg_analyzer.num_paths() == num_paths);
+    CHECK(svg_analyzer.num_polygons() == num_polygons);
+    CHECK(svg_analyzer.num_polylines() == 0);
+    CHECK(svg_analyzer.num_rects() == 0);
+    CHECK(svg_analyzer.num_titles() == num_titles);
+    CHECK(svg_analyzer.num_unknowns() == 0);
+
+    gvFreeRenderData(result);
+  }
+
+  for (Agraph_t *subg = agfstsubg(g); subg; subg = agnxtsubg(subg)) {
+    gvFreeLayout(gvc, subg);
+  }
+
+  agclose(g);
+  gvFreeContext(gvc);
+}