From: Bram Moolenaar <Bram@vim.org>
Date: Tue, 21 May 2019 18:54:45 +0000 (+0200)
Subject: patch 8.1.1363: ":vert options" does not make a vertical split
X-Git-Tag: v8.1.1363
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=e0b5949a3b28be9940bb8a46b2579e960100b83b;p=vim

patch 8.1.1363: ":vert options" does not make a vertical split

Problem:    ":vert options" does not make a vertical split.
Solution:   Pass the right modifiers in $OPTWIN_CMD. (Ken Takata,
            closes #4401)
---

diff --git a/src/ex_cmds2.c b/src/ex_cmds2.c
index 18c438ce0..bf6e55120 100644
--- a/src/ex_cmds2.c
+++ b/src/ex_cmds2.c
@@ -3016,7 +3016,9 @@ ex_packadd(exarg_T *eap)
 ex_options(
     exarg_T	*eap UNUSED)
 {
-    vim_setenv((char_u *)"OPTWIN_CMD", (char_u *)(cmdmod.tab ? "tab" : ""));
+    vim_setenv((char_u *)"OPTWIN_CMD",
+	    (char_u *)(cmdmod.tab ? "tab"
+		: (cmdmod.split & WSP_VERT) ? "vert" : ""));
     cmd_source((char_u *)SYS_OPTWIN_FILE, NULL);
 }
 #endif
diff --git a/src/testdir/test_options.vim b/src/testdir/test_options.vim
index c5dbb9f4c..13de71934 100644
--- a/src/testdir/test_options.vim
+++ b/src/testdir/test_options.vim
@@ -51,6 +51,32 @@ func Test_options()
   endtry
   call assert_equal('ok', caught)
 
+  " Check if the option-window is opened horizontally.
+  wincmd j
+  call assert_notequal('option-window', bufname(''))
+  wincmd k
+  call assert_equal('option-window', bufname(''))
+  " close option-window
+  close
+
+  " Open the option-window vertically.
+  vert options
+  " Check if the option-window is opened vertically.
+  wincmd l
+  call assert_notequal('option-window', bufname(''))
+  wincmd h
+  call assert_equal('option-window', bufname(''))
+  " close option-window
+  close
+
+  " Open the option-window in a new tab.
+  tab options
+  " Check if the option-window is opened in a tab.
+  normal gT
+  call assert_notequal('option-window', bufname(''))
+  normal gt
+  call assert_equal('option-window', bufname(''))
+
   " close option-window
   close
 endfunc
diff --git a/src/version.c b/src/version.c
index cdcd132e4..fb7dad390 100644
--- a/src/version.c
+++ b/src/version.c
@@ -767,6 +767,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1363,
 /**/
     1362,
 /**/