From: Reid Kleckner <rnk@google.com>
Date: Mon, 29 Apr 2019 19:56:46 +0000 (+0000)
Subject: Fix string UAF in new FileCheck test
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=de608b0409aa74f6b2e5eca519b46478c72c70e5;p=llvm

Fix string UAF in new FileCheck test

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359493 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/unittests/Support/FileCheckTest.cpp b/unittests/Support/FileCheckTest.cpp
index e120cbe5f1f..682f3246715 100644
--- a/unittests/Support/FileCheckTest.cpp
+++ b/unittests/Support/FileCheckTest.cpp
@@ -98,7 +98,7 @@ private:
 
 public:
   bool parseExpect(std::string &VarName, std::string &Trailer) {
-    StringRef NameTrailer = StringRef(VarName + Trailer);
+    std::string NameTrailer = VarName + Trailer;
     std::unique_ptr<MemoryBuffer> Buffer =
         MemoryBuffer::getMemBufferCopy(NameTrailer, "TestBuffer");
     StringRef NameTrailerRef = Buffer->getBuffer();