From: Nico Weber Date: Mon, 19 Oct 2015 16:21:29 +0000 (+0000) Subject: clang-format: Use pipes instead of temporary files for most lit tests. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=de5085648a67a15f94922277fd6f7f3ab8f5d3f9;p=clang clang-format: Use pipes instead of temporary files for most lit tests. This makes the format tests look more like most other FileCheck tests in clang. The multiple-inputs tests still use temp files, to make sure that the file input code in clang-format stays tested. Stop stripping out the comment lines in style-on-command-line.cpp as they don't get in the way and it makes the test simpler. Also remove 2>&1s on the tests in that file that don't need it. http://reviews.llvm.org/D13852 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@250706 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/test/Format/basic.cpp b/test/Format/basic.cpp index a12866b9c1..e92291d04d 100644 --- a/test/Format/basic.cpp +++ b/test/Format/basic.cpp @@ -1,6 +1,5 @@ -// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp -// RUN: clang-format -style=LLVM -i %t.cpp -// RUN: FileCheck -strict-whitespace -input-file=%t.cpp %s +// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format -style=LLVM \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: {{^int\ \*i;}} int * i ; diff --git a/test/Format/cursor.cpp b/test/Format/cursor.cpp index c7d576ba6e..b0a2fbdffc 100644 --- a/test/Format/cursor.cpp +++ b/test/Format/cursor.cpp @@ -1,6 +1,5 @@ -// RUN: grep -Ev "// *[A-Z-]+:" %s > %t2.cpp -// RUN: clang-format -style=LLVM %t2.cpp -cursor=6 > %t.cpp -// RUN: FileCheck -strict-whitespace -input-file=%t.cpp %s +// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format -style=LLVM -cursor=6 \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: {{^\{ "Cursor": 4, }} // CHECK: {{^int\ \i;$}} int i; diff --git a/test/Format/disable-format.cpp b/test/Format/disable-format.cpp index 59484b3df1..a1e8cd1508 100644 --- a/test/Format/disable-format.cpp +++ b/test/Format/disable-format.cpp @@ -1,6 +1,5 @@ -// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp -// RUN: clang-format -style=none -i %t.cpp -// RUN: FileCheck -strict-whitespace -input-file=%t.cpp %s +// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format -style=none \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: int i; int i; diff --git a/test/Format/incomplete.cpp b/test/Format/incomplete.cpp index bd2c74ca3c..8a65fad657 100644 --- a/test/Format/incomplete.cpp +++ b/test/Format/incomplete.cpp @@ -1,6 +1,5 @@ -// RUN: grep -Ev "// *[A-Z-]+:" %s > %t2.cpp -// RUN: clang-format -style=LLVM %t2.cpp -cursor=0 > %t.cpp -// RUN: FileCheck -strict-whitespace -input-file=%t.cpp %s +// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format -style=LLVM -cursor=0 \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: {{"IncompleteFormat": true}} // CHECK: {{^int\ \i;$}} int i; diff --git a/test/Format/language-detection.cpp b/test/Format/language-detection.cpp index bec444dc9d..2a53be71da 100644 --- a/test/Format/language-detection.cpp +++ b/test/Format/language-detection.cpp @@ -1,7 +1,9 @@ -// RUN: grep -Ev "// *[A-Z0-9_]+:" %s > %t.js -// RUN: grep -Ev "// *[A-Z0-9_]+:" %s > %t.cpp -// RUN: clang-format -style=llvm %t.js | FileCheck -strict-whitespace -check-prefix=CHECK1 %s -// RUN: clang-format -style=llvm %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK2 %s +// RUN: grep -Ev "// *[A-Z0-9_]+:" %s \ +// RUN: | clang-format -style=llvm -assume-filename=foo.js \ +// RUN: | FileCheck -strict-whitespace -check-prefix=CHECK1 %s +// RUN: grep -Ev "// *[A-Z0-9_]+:" %s \ +// RUN: | clang-format -style=llvm -assume-filename=foo.cpp \ +// RUN: | FileCheck -strict-whitespace -check-prefix=CHECK2 %s // CHECK1: {{^a >>>= b;$}} // CHECK2: {{^a >> >= b;$}} a >>>= b; diff --git a/test/Format/line-ranges.cpp b/test/Format/line-ranges.cpp index 370445aed1..9099022b42 100644 --- a/test/Format/line-ranges.cpp +++ b/test/Format/line-ranges.cpp @@ -1,6 +1,6 @@ -// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp -// RUN: clang-format -style=LLVM -lines=1:1 -lines=5:5 -i %t.cpp -// RUN: FileCheck -strict-whitespace -input-file=%t.cpp %s +// RUN: grep -Ev "// *[A-Z-]+:" %s \ +// RUN: | clang-format -style=LLVM -lines=1:1 -lines=5:5 \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: {{^int\ \*i;$}} int*i; diff --git a/test/Format/ranges.cpp b/test/Format/ranges.cpp index c7fdd4b97a..ace528a916 100644 --- a/test/Format/ranges.cpp +++ b/test/Format/ranges.cpp @@ -1,6 +1,6 @@ -// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp -// RUN: clang-format -style=LLVM -offset=2 -length=0 -offset=28 -length=0 -i %t.cpp -// RUN: FileCheck -strict-whitespace -input-file=%t.cpp %s +// RUN: grep -Ev "// *[A-Z-]+:" %s \ +// RUN: | clang-format -style=LLVM -offset=2 -length=0 -offset=28 -length=0 \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: {{^int\ \*i;$}} int*i; diff --git a/test/Format/style-on-command-line.cpp b/test/Format/style-on-command-line.cpp index 3f4f77ad0c..08da60a988 100644 --- a/test/Format/style-on-command-line.cpp +++ b/test/Format/style-on-command-line.cpp @@ -1,17 +1,16 @@ -// RUN: grep -Ev "// *[A-Z0-9_]+:" %s > %t.cpp -// RUN: clang-format -style="{BasedOnStyle: Google, IndentWidth: 8}" %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK1 %s -// RUN: clang-format -style="{BasedOnStyle: LLVM, IndentWidth: 7}" %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK2 %s -// RUN: clang-format -style="{BasedOnStyle: invalid, IndentWidth: 7}" -fallback-style=LLVM %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK3 %s -// RUN: clang-format -style="{lsjd}" %t.cpp -fallback-style=LLVM 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK4 %s +// RUN: clang-format -style="{BasedOnStyle: Google, IndentWidth: 8}" %s | FileCheck -strict-whitespace -check-prefix=CHECK1 %s +// RUN: clang-format -style="{BasedOnStyle: LLVM, IndentWidth: 7}" %s | FileCheck -strict-whitespace -check-prefix=CHECK2 %s +// RUN: clang-format -style="{BasedOnStyle: invalid, IndentWidth: 7}" -fallback-style=LLVM %s 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK3 %s +// RUN: clang-format -style="{lsjd}" %s -fallback-style=LLVM 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK4 %s // RUN: printf "BasedOnStyle: google\nIndentWidth: 5\n" > %T/.clang-format -// RUN: clang-format -style=file %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK5 %s +// RUN: clang-format -style=file -assume-filename=%T/foo.cpp < %s | FileCheck -strict-whitespace -check-prefix=CHECK5 %s // RUN: printf "\n" > %T/.clang-format -// RUN: clang-format -style=file -fallback-style=webkit %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK6 %s +// RUN: clang-format -style=file -fallback-style=webkit -assume-filename=%T/foo.cpp < %s 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK6 %s // RUN: rm %T/.clang-format // RUN: printf "BasedOnStyle: google\nIndentWidth: 6\n" > %T/_clang-format -// RUN: clang-format -style=file %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK7 %s -// RUN: clang-format -style="{BasedOnStyle: LLVM, PointerBindsToType: true}" %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK8 %s -// RUN: clang-format -style="{BasedOnStyle: WebKit, PointerBindsToType: false}" %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK9 %s +// RUN: clang-format -style=file -assume-filename=%T/foo.cpp < %s | FileCheck -strict-whitespace -check-prefix=CHECK7 %s +// RUN: clang-format -style="{BasedOnStyle: LLVM, PointerBindsToType: true}" %s | FileCheck -strict-whitespace -check-prefix=CHECK8 %s +// RUN: clang-format -style="{BasedOnStyle: WebKit, PointerBindsToType: false}" %s | FileCheck -strict-whitespace -check-prefix=CHECK9 %s void f() { // CHECK1: {{^ int\* i;$}} // CHECK2: {{^ int \*i;$}} diff --git a/test/Format/xmloutput.cpp b/test/Format/xmloutput.cpp index d3c5254fc3..3d84a2f5e4 100644 --- a/test/Format/xmloutput.cpp +++ b/test/Format/xmloutput.cpp @@ -1,5 +1,5 @@ -// RUN: clang-format -output-replacements-xml -sort-includes %s > %t.xml -// RUN: FileCheck -strict-whitespace -input-file=%t.xml %s +// RUN: clang-format -output-replacements-xml -sort-includes %s \ +// RUN: | FileCheck -strict-whitespace %s // CHECK: