From: Scott MacVicar <scottmac@php.net>
Date: Tue, 17 Mar 2009 02:00:08 +0000 (+0000)
Subject: Fix bug #47644 - Valid integers are truncated with json_decode()
X-Git-Tag: php-5.4.0alpha1~191^2~4134
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=de4891ab2aa9827d70a0f1b53499670268294cab;p=php

Fix bug #47644 - Valid integers are truncated with json_decode()
---

diff --git a/ext/json/JSON_parser.c b/ext/json/JSON_parser.c
index c4cb6ca582..ec874a7ec2 100644
--- a/ext/json/JSON_parser.c
+++ b/ext/json/JSON_parser.c
@@ -289,11 +289,11 @@ static void json_create_zval(zval **z, smart_str *buf, int type TSRMLS_DC)
 
     if (type == IS_LONG)
     {
-		double d = zend_strtod(buf->c, NULL);
-		if (d > LONG_MAX || d < LONG_MIN) {
-			ZVAL_DOUBLE(*z, d);
+		long l = strtol(buf->c, NULL, 10);
+		if (l > LONG_MAX || l < LONG_MIN) {
+			ZVAL_DOUBLE(*z, zend_strtod(buf->c, NULL));
 		} else {
-			ZVAL_LONG(*z, (long)d);
+			ZVAL_LONG(*z, l);
 		}
     }
     else if (type == IS_DOUBLE)
diff --git a/ext/json/tests/bug47644.phpt b/ext/json/tests/bug47644.phpt
new file mode 100644
index 0000000000..5e996b6973
--- /dev/null
+++ b/ext/json/tests/bug47644.phpt
@@ -0,0 +1,43 @@
+--TEST--
+Bug #47644 (valid large integers are truncated)
+--SKIPIF--
+<?php
+  if (!extension_loaded('json')) die('skip: json extension not available');
+  if (PHP_INT_SIZE != 8) die("skip this test is for 64bit platform only");
+?>
+--FILE--
+<?php
+
+for ($i = 10000000000000000; $i < 10000000000000006; $i++) {
+	var_dump(json_decode("[$i]"));
+}
+
+
+echo "Done\n";
+?>
+--EXPECT--	
+array(1) {
+  [0]=>
+  int(10000000000000000)
+}
+array(1) {
+  [0]=>
+  int(10000000000000001)
+}
+array(1) {
+  [0]=>
+  int(10000000000000002)
+}
+array(1) {
+  [0]=>
+  int(10000000000000003)
+}
+array(1) {
+  [0]=>
+  int(10000000000000004)
+}
+array(1) {
+  [0]=>
+  int(10000000000000005)
+}
+Done