From: Ned Deily Date: Sat, 4 Mar 2017 11:00:37 +0000 (-0500) Subject: bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. (#462) X-Git-Tag: v3.7.0a1~1206 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=de04644627f82d9dc48b3423def7ff5b4aa1926a;p=python bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. (#462) * bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS Skip some tests of select.poll when running on macOS due to unresolved issues with the underlying system poll function on some macOS versions. --- diff --git a/Lib/test/eintrdata/eintr_tester.py b/Lib/test/eintrdata/eintr_tester.py index d194e775ea..c619b3d6c3 100644 --- a/Lib/test/eintrdata/eintr_tester.py +++ b/Lib/test/eintrdata/eintr_tester.py @@ -437,6 +437,8 @@ class SelectEINTRTest(EINTRBaseTest): self.stop_alarm() self.assertGreaterEqual(dt, self.sleep_time) + @unittest.skipIf(sys.platform == "darwin", + "poll may fail on macOS; see issue #28087") @unittest.skipUnless(hasattr(select, 'poll'), 'need select.poll') def test_poll(self): poller = select.poll() diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py index 51c65737a4..d05462b7ef 100644 --- a/Lib/test/test_asyncore.py +++ b/Lib/test/test_asyncore.py @@ -661,6 +661,9 @@ class BaseTestAPI: if HAS_UNIX_SOCKETS and self.family == socket.AF_UNIX: self.skipTest("Not applicable to AF_UNIX sockets.") + if sys.platform == "darwin" and self.use_poll: + self.skipTest("poll may fail on macOS; see issue #28087") + class TestClient(BaseClient): def handle_expt(self): self.socket.recv(1024, socket.MSG_OOB) diff --git a/Misc/NEWS b/Misc/NEWS index 899723937c..3ff3cb5b8b 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -895,6 +895,10 @@ Tools/Demos Tests ----- +- bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. + Skip some tests of select.poll when running on macOS due to unresolved + issues with the underlying system poll function on some macOS versions. + - Issue #29571: to match the behaviour of the ``re.LOCALE`` flag, test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to determine the candidate encoding for the test regex (allowing it to correctly