From: LOLi Date: Fri, 21 Sep 2018 16:42:42 +0000 (+0200) Subject: vdev_disk_error() prints ASCII SOH to debug log X-Git-Tag: zfs-0.8.0-rc2~97 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=dda5500853c736aca9ad8c14f7d22cd9d9f9fb36;p=zfs vdev_disk_error() prints ASCII SOH to debug log Currently vdev_disk_error() prepends its messages sent to the internal ZFS debug log with KERN_WARNING, which is currently defined as follows: #define KERN_SOH "\001" #define KERN_WARNING KERN_SOH "4" Since "\001" (ASCII Start Of Header) is not printable this results in weird characters displayed when inspecting the debug log. This commit simply removes this superfluous prefix passed to zfs_dbgmsg(). Reviewed-by: Giuseppe Di Natale Reviewed-by: George Melikov Reviewed-by: Brian Behlendorf Reviewed-by: Richard Laager Signed-off-by: loli10K Closes #7936 --- diff --git a/module/zfs/vdev_disk.c b/module/zfs/vdev_disk.c index 78741af7f..a4109543d 100644 --- a/module/zfs/vdev_disk.c +++ b/module/zfs/vdev_disk.c @@ -139,10 +139,9 @@ bdev_max_capacity(struct block_device *bdev, uint64_t wholedisk) static void vdev_disk_error(zio_t *zio) { - zfs_dbgmsg(KERN_WARNING "zio error=%d type=%d offset=%llu size=%llu " - "flags=%x\n", zio->io_error, zio->io_type, - (u_longlong_t)zio->io_offset, (u_longlong_t)zio->io_size, - zio->io_flags); + zfs_dbgmsg("zio error=%d type=%d offset=%llu size=%llu flags=%x\n", + zio->io_error, zio->io_type, (u_longlong_t)zio->io_offset, + (u_longlong_t)zio->io_size, zio->io_flags); } /*